From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35100)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZMw9q-0004qR-RD
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 06:42:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZMw9m-0004do-O2
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 06:42:50 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44057)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dgilbert@redhat.com>) id 1ZMw9m-0004cr-IO
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 06:42:46 -0400
Date: Wed, 5 Aug 2015 11:42:39 +0100
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Message-ID: <20150805104238.GE2331@work-vm>
References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com>
	<1438159544-6224-25-git-send-email-zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438159544-6224-25-git-send-email-zhang.zhanghailiang@huawei.com>
Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 24/34] COLO NIC: Implement
 colo nic device interface configure()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>
Cc: lizhijian@cn.fujitsu.com, quintela@redhat.com, Jason Wang <jasowang@redhat.com>, yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, Stefan Hajnoczi <stefanha@redhat.com>, amit.shah@redhat.com

* zhanghailiang (zhang.zhanghailiang@huawei.com) wrote:
> Implement colo nic device interface configure()
> add a script to configure nic devices:
> ${QEMU_SCRIPT_DIR}/colo-proxy-script.sh
> 
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---

I've not quite got this working right yet;  after a failover, the secondary
hasn't connected the tap to the right bridge; I'm still trying to figure that out.

> +
> +secondary_uninstall()
> +{
> +    brctl delif $br $phy_if
> +    brctl delif $br $virt_if
> +    brctl addif $failover_br $virt_if
> +
> +    /usr/local/sbin/iptables -t mangle -D PREROUTING -m physdev --physdev-in \
> +        $virt_if -j SECCOLO --index $index

I think this is new in this version;  don't you still need the SECCOLO
mangle to fixup the sequence number of packets in existing connections so they
match the numbers that the PMY used?

Dave

> +    /usr/local/sbin/ip6tables -t mangle -D PREROUTING -m physdev --physdev-in \
> +        $virt_if -j SECCOLO --index $index
> +}
> +
> +if [ $# -ne 5 ]; then
> +    script_usage
> +    exit 1
> +fi
> +
> +if [ "x$side" != "xprimary" ] && [ "x$side" != "xsecondary" ]; then
> +    script_usage
> +    exit 2
> +fi
> +
> +if [ "x$action" != "xinstall" ] && [ "x$action" != "xuninstall" ]; then
> +    script_usage
> +    exit 3
> +fi
> +
> +${side}_${action}
> -- 
> 1.8.3.1
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK