From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alberto Garcia <berto@igalia.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] throttle: refuse bps_max/iops_max without bps/iops
Date: Wed, 5 Aug 2015 12:54:20 +0100 [thread overview]
Message-ID: <20150805115420.GA23323@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1438683733-21111-1-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Tue, Aug 04, 2015 at 11:22:11AM +0100, Stefan Hajnoczi wrote:
> A bps_max/iops_max value without a corresponding bps/iops does nothing. Avoid
> confusing the user by refusing invalid inputs instead of silently ignoring
> them.
>
> Stefan Hajnoczi (2):
> throttle: refuse bps_max/iops_max without bps/iops
> throttle: add throttle_max_is_missing_limit() test
>
> blockdev.c | 6 ++++++
> include/qemu/throttle.h | 2 ++
> tests/test-throttle.c | 21 +++++++++++++++++++++
> util/throttle.c | 15 +++++++++++++++
> 4 files changed, 44 insertions(+)
>
> --
> 2.4.3
>
Thanks, applied to my block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-05 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 10:22 [Qemu-devel] [PATCH 0/2] throttle: refuse bps_max/iops_max without bps/iops Stefan Hajnoczi
2015-08-04 10:22 ` [Qemu-devel] [PATCH 1/2] " Stefan Hajnoczi
2015-08-04 11:12 ` Alberto Garcia
2015-08-04 10:22 ` [Qemu-devel] [PATCH 2/2] throttle: add throttle_max_is_missing_limit() test Stefan Hajnoczi
2015-08-04 11:12 ` Alberto Garcia
2015-08-05 11:54 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805115420.GA23323@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).