From: Victor kaplansky <victork@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files.
Date: Wed, 5 Aug 2015 21:22:09 +0300 [thread overview]
Message-ID: <20150805211340-mutt-send-email-victork@redhat.com> (raw)
In-Reply-To: <55C24A70.1080800@redhat.com>
On Wed, Aug 05, 2015 at 07:40:00PM +0200, Paolo Bonzini wrote:
>
>
> On 05/08/2015 19:29, Victor Kaplansky wrote:
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index bd4f147..311d364 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -10,6 +10,8 @@ obj-y += acpi-build.o
> > hw/i386/acpi-build.o: hw/i386/acpi-build.c \
> > hw/i386/acpi-dsdt.hex hw/i386/q35-acpi-dsdt.hex
> >
> > +-include hw/i386/acpi-dsdt.d hw/i386/q35-acpi-dsdt.d
> > +
>
> Having to include the files manually is ugly though.
>
> The failed builds are ugly too, but I'm not sure which is worse... :(
> Failed builds happen rarely and there are other cases where you should
> just "make distclean" your way out of a failure. On the other hand,
> more complicated makefiles have to be maintained always.
Actually there is no problem to keep the list of generated *.hex targets
as we do for *.o objects. Just current list is very short, only two
items, so I leaved them as is.
--Victor
next prev parent reply other threads:[~2015-08-05 18:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 17:27 [Qemu-devel] [PATCH v2 0/2] make: Cleanup and fix of loading of dependency info Victor Kaplansky
2015-08-05 17:28 ` [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored Victor Kaplansky
2015-08-06 8:57 ` Alex Bennée
2015-08-06 9:02 ` Michael S. Tsirkin
2015-08-06 15:55 ` Alex Bennée
2015-08-05 17:29 ` [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files Victor Kaplansky
2015-08-05 17:40 ` Paolo Bonzini
2015-08-05 18:22 ` Victor kaplansky [this message]
2015-08-06 7:05 ` Markus Armbruster
2015-08-05 18:32 ` Michael S. Tsirkin
2015-08-05 18:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805211340-mutt-send-email-victork@redhat.com \
--to=victork@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).