From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36680)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3Kd-0005Dr-2i
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:22:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3KZ-0003TZ-SW
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:22:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58794)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3KZ-0003TV-Nj
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:22:23 -0400
Date: Wed, 5 Aug 2015 21:22:09 +0300
From: Victor kaplansky <victork@redhat.com>
Message-ID: <20150805211340-mutt-send-email-victork@redhat.com>
References: <1438795570-3930-1-git-send-email-victork@redhat.com>
	<1438795570-3930-3-git-send-email-victork@redhat.com>
	<55C24A70.1080800@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55C24A70.1080800@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency
	files.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>

On Wed, Aug 05, 2015 at 07:40:00PM +0200, Paolo Bonzini wrote:
> 
> 
> On 05/08/2015 19:29, Victor Kaplansky wrote:
> > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs
> > index bd4f147..311d364 100644
> > --- a/hw/i386/Makefile.objs
> > +++ b/hw/i386/Makefile.objs
> > @@ -10,6 +10,8 @@ obj-y += acpi-build.o
> >  hw/i386/acpi-build.o: hw/i386/acpi-build.c \
> >  	hw/i386/acpi-dsdt.hex hw/i386/q35-acpi-dsdt.hex
> >  
> > +-include hw/i386/acpi-dsdt.d hw/i386/q35-acpi-dsdt.d
> > +
> 
> Having to include the files manually is ugly though.
> 
> The failed builds are ugly too, but I'm not sure which is worse... :(
> Failed builds happen rarely and there are other cases where you should
> just "make distclean" your way out of a failure.  On the other hand,
> more complicated makefiles have to be maintained always.

Actually there is no problem to keep the list of generated *.hex targets
as we do for *.o objects. Just current list is very short, only two
items, so I leaved them as is.

--Victor