From: "Michael S. Tsirkin" <victork@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files.
Date: Wed, 5 Aug 2015 21:51:57 +0300 [thread overview]
Message-ID: <20150805214903-mutt-send-email-victork@redhat.com> (raw)
In-Reply-To: <20150805213155-mutt-send-email-mst@redhat.com>
On Wed, Aug 05, 2015 at 09:32:18PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 08:29:33PM +0300, Victor Kaplansky wrote:
...
> > diff --git a/rules.mak b/rules.mak
> > index 6e35c36..4551b9e 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -368,6 +368,6 @@ define unnest-vars
> > $(error $o added in $v but $o-objs is not set)))
> > $(shell mkdir -p ./ $(sort $(dir $($v))))
> > # Include all the .d files
> > - $(eval -include $(addsuffix *.d, $(sort $(dir $($v)))))
> > + $(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v))))
>
> Pls add space after comma, like it was in the original.
For patsubst comma is pattern delimiter, so if inserted it would be part
of the pattern. Should I add a comment on this?
--Victor
prev parent reply other threads:[~2015-08-05 18:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 17:27 [Qemu-devel] [PATCH v2 0/2] make: Cleanup and fix of loading of dependency info Victor Kaplansky
2015-08-05 17:28 ` [Qemu-devel] [PATCH v2 1/2] make: fix where dependency *.d are stored Victor Kaplansky
2015-08-06 8:57 ` Alex Bennée
2015-08-06 9:02 ` Michael S. Tsirkin
2015-08-06 15:55 ` Alex Bennée
2015-08-05 17:29 ` [Qemu-devel] [PATCH v2 2/2] make: load only required dependency files Victor Kaplansky
2015-08-05 17:40 ` Paolo Bonzini
2015-08-05 18:22 ` Victor kaplansky
2015-08-06 7:05 ` Markus Armbruster
2015-08-05 18:32 ` Michael S. Tsirkin
2015-08-05 18:51 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805214903-mutt-send-email-victork@redhat.com \
--to=victork@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).