From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3nh-00062z-97
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:52:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3nZ-0001gb-5Q
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:52:29 -0400
Received: from mx1.redhat.com ([209.132.183.28]:55042)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <victork@redhat.com>) id 1ZN3nZ-0001gN-0t
	for qemu-devel@nongnu.org; Wed, 05 Aug 2015 14:52:21 -0400
Date: Wed, 5 Aug 2015 21:51:57 +0300
From: "Michael S. Tsirkin" <victork@redhat.com>
Message-ID: <20150805214903-mutt-send-email-victork@redhat.com>
References: <1438795570-3930-1-git-send-email-victork@redhat.com>
	<1438795570-3930-3-git-send-email-victork@redhat.com>
	<20150805213155-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150805213155-mutt-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] make: load only required dependency
	files.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

On Wed, Aug 05, 2015 at 09:32:18PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 08:29:33PM +0300, Victor Kaplansky wrote:
...
> > diff --git a/rules.mak b/rules.mak
> > index 6e35c36..4551b9e 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -368,6 +368,6 @@ define unnest-vars
> >                  $(error $o added in $v but $o-objs is not set)))
> >          $(shell mkdir -p ./ $(sort $(dir $($v))))
> >          # Include all the .d files
> > -        $(eval -include $(addsuffix *.d, $(sort $(dir $($v)))))
> > +        $(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v))))
> 
> Pls add space after comma, like it was in the original.

For patsubst comma is pattern delimiter, so if inserted it would be part
of the pattern.  Should I add a comment on this?

--Victor