From: Stefan Hajnoczi <stefanha@gmail.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/5] block: Drop BDS.filename
Date: Thu, 6 Aug 2015 10:44:36 +0100 [thread overview]
Message-ID: <20150806094436.GF19585@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1438807969-9723-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On Wed, Aug 05, 2015 at 10:52:44PM +0200, Max Reitz wrote:
> Regarding the fear that this might change current behavior, especially
> for libvirt which used filenames to identify nodes in the BDS graph:
> Since bdrv_open() already calls bdrv_refresh_filename() today, and
> apparently everything works fine, this series will most likely not break
> anything. The only thing that will change is if the BDS graph is
> dynamically reconfigured at runtime, and in that case it's most likely a
> bug fix. Also, I don't think libvirt supports such cases already.
I haven't reviewed the patches but seems like a perfectly reasonable
thing to do at the beginning of the QEMU 2.5 development cycle. If
anything comes up there will be time ot fix it before the next QEMU
version is released.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-08-06 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 20:52 [Qemu-devel] [PATCH v2 0/5] block: Drop BDS.filename Max Reitz
2015-08-05 20:52 ` [Qemu-devel] [PATCH v2 1/5] block: Change bdrv_get_encrypted_filename() Max Reitz
2015-08-06 2:01 ` Wen Congyang
2015-08-07 14:37 ` Max Reitz
2015-08-05 20:52 ` [Qemu-devel] [PATCH v2 2/5] block: Avoid BlockDriverState.filename Max Reitz
2015-08-06 2:27 ` Wen Congyang
2015-08-07 14:56 ` Max Reitz
2015-08-05 20:52 ` [Qemu-devel] [PATCH v2 3/5] block: Add bdrv_filename() Max Reitz
2015-08-05 20:52 ` [Qemu-devel] [PATCH v2 4/5] block: Drop BlockDriverState.filename Max Reitz
2015-08-05 20:52 ` [Qemu-devel] [PATCH v2 5/5] iotests: Test changed Quorum filename Max Reitz
2015-08-06 9:44 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150806094436.GF19585@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).