From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNHjD-00006u-VZ for qemu-devel@nongnu.org; Thu, 06 Aug 2015 05:44:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNHjC-0006GV-Q7 for qemu-devel@nongnu.org; Thu, 06 Aug 2015 05:44:47 -0400 Date: Thu, 6 Aug 2015 10:44:36 +0100 From: Stefan Hajnoczi Message-ID: <20150806094436.GF19585@stefanha-thinkpad.redhat.com> References: <1438807969-9723-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Zi0sgQQBxRFxMTsj" Content-Disposition: inline In-Reply-To: <1438807969-9723-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/5] block: Drop BDS.filename List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Stefan Hajnoczi , qemu-devel@nongnu.org, qemu-block@nongnu.org --Zi0sgQQBxRFxMTsj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 05, 2015 at 10:52:44PM +0200, Max Reitz wrote: > Regarding the fear that this might change current behavior, especially > for libvirt which used filenames to identify nodes in the BDS graph: > Since bdrv_open() already calls bdrv_refresh_filename() today, and > apparently everything works fine, this series will most likely not break > anything. The only thing that will change is if the BDS graph is > dynamically reconfigured at runtime, and in that case it's most likely a > bug fix. Also, I don't think libvirt supports such cases already. I haven't reviewed the patches but seems like a perfectly reasonable thing to do at the beginning of the QEMU 2.5 development cycle. If anything comes up there will be time ot fix it before the next QEMU version is released. --Zi0sgQQBxRFxMTsj Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVwyyEAAoJEJykq7OBq3PI0L8H/i8UWO6AFLMV45+6zrycxWLW 8NBfrqXTobfhVqQLUSpvhmA56CkZhlHBu1wk1lUyaxxGCpRfZUrJNjLHBezH4Q0d yG1nCkKcAqEbnV3vFKwp6ihKD824ySAyujKQhTYrNKVRRA7zfn/CKFV+c1a7koEX eaiBtKnaA1DZV0WUYW8Fr7ckUsLI3zJo4ArnK19CpIlqAa3WInqII9d81eLoae9N irQyAaDN7C7pgLUoZ45UbLgNLeE/3RJ59e9SvniyomxYvAwHkgYqj6VsM9NY2Vgq 9WBv5uwZ/eJnHweoOKt7pDZBebhJh7UkMITVK9bagc6i45oMAuDxP8cK6f9soiw= =LlZb -----END PGP SIGNATURE----- --Zi0sgQQBxRFxMTsj--