* [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
@ 2015-08-06 11:10 Samuel Thibault
2015-08-10 10:18 ` Stefan Hajnoczi
2016-03-07 12:14 ` Jan Kiszka
0 siblings, 2 replies; 8+ messages in thread
From: Samuel Thibault @ 2015-08-06 11:10 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> On 2015-07-29 00:12, Samuel Thibault wrote:
> > Hello,
> >
> > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> >> Of course, I'm fine with handing this over to someone who'd like to
> >> pick up. Do we have volunteers?
> >>
> >> Samuel, would you like to do this? As a subsystem maintainer, you are
> >> already familiar with QEMU processes.
> >
> > I can help with maintenance, yes.
>
> "Help with" will easily mean "be the one and only". ;)
Right, I understand that :) That's still preferable to have two contact
people.
diff --git a/MAINTAINERS b/MAINTAINERS
index 978b717..b506df5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1018,6 +1018,7 @@ F: scripts/qmp/
T: git git://repo.or.cz/qemu/armbru.git qapi-next
SLIRP
+M: Samuel Thibault <samuel.thibault@ens-lyon.org>
M: Jan Kiszka <jan.kiszka@siemens.com>
S: Maintained
F: slirp/
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-08-06 11:10 [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
@ 2015-08-10 10:18 ` Stefan Hajnoczi
2016-03-07 12:14 ` Jan Kiszka
1 sibling, 0 replies; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-08-10 10:18 UTC (permalink / raw)
To: Samuel Thibault; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 841 bytes --]
On Thu, Aug 06, 2015 at 01:10:14PM +0200, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> ---
> Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> > On 2015-07-29 00:12, Samuel Thibault wrote:
> > > Hello,
> > >
> > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> > >> Of course, I'm fine with handing this over to someone who'd like to
> > >> pick up. Do we have volunteers?
> > >>
> > >> Samuel, would you like to do this? As a subsystem maintainer, you are
> > >> already familiar with QEMU processes.
> > >
> > > I can help with maintenance, yes.
> >
> > "Help with" will easily mean "be the one and only". ;)
>
> Right, I understand that :) That's still preferable to have two contact
> people.
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-08-06 11:10 [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
2015-08-10 10:18 ` Stefan Hajnoczi
@ 2016-03-07 12:14 ` Jan Kiszka
1 sibling, 0 replies; 8+ messages in thread
From: Jan Kiszka @ 2016-03-07 12:14 UTC (permalink / raw)
To: Samuel Thibault, qemu-devel
On 2015-08-06 13:10, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> ---
> Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
>> On 2015-07-29 00:12, Samuel Thibault wrote:
>>> Hello,
>>>
>>> Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
>>>> Of course, I'm fine with handing this over to someone who'd like to
>>>> pick up. Do we have volunteers?
>>>>
>>>> Samuel, would you like to do this? As a subsystem maintainer, you are
>>>> already familiar with QEMU processes.
>>>
>>> I can help with maintenance, yes.
>>
>> "Help with" will easily mean "be the one and only". ;)
>
> Right, I understand that :) That's still preferable to have two contact
> people.
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 978b717..b506df5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1018,6 +1018,7 @@ F: scripts/qmp/
> T: git git://repo.or.cz/qemu/armbru.git qapi-next
>
> SLIRP
> +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
> M: Jan Kiszka <jan.kiszka@siemens.com>
> S: Maintained
> F: slirp/
>
Acked-by: Jan Kiszka <jan.kiszka@siemens.com>
Thanks a lot, Samuel, for offering your help! I know how full your
agenda already is, so it's even more appreciated.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
@ 2015-07-20 10:32 Stefan Hajnoczi
2015-07-20 11:55 ` zhanghailiang
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-07-20 10:32 UTC (permalink / raw)
To: Li Zhijian
Cc: zhanghailiang, jan.kiszka, jasowang, peter.huangpeng, qemu-devel,
Gonglei (Arei), stefanha, Yang Hongyang, dgilbert
[-- Attachment #1: Type: text/plain, Size: 718 bytes --]
On Mon, Jul 20, 2015 at 02:42:33PM +0800, Li Zhijian wrote:
> We are planning to implement colo-proxy in qemu to cache and compare packets.
I thought there is a kernel module to do that?
Why does the proxy need to be part of the QEMU process? -netdev socket
or host network stack features allow you to process packets in a
separate process.
Without details on what the proxy does it's hard to discuss this. What
happens in the non-TCP case? What happens in the TCP case?
Does the proxy need to perform privileged operations, create sockets,
open files, etc?
The slirp code is not actively developed or used much in production. It
might be a good idea to audit the code for bugs if you want to use it.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-20 10:32 [Qemu-devel] [POC] colo-proxy in qemu Stefan Hajnoczi
@ 2015-07-20 11:55 ` zhanghailiang
2015-07-20 13:12 ` Vasiliy Tolstov
0 siblings, 1 reply; 8+ messages in thread
From: zhanghailiang @ 2015-07-20 11:55 UTC (permalink / raw)
To: Stefan Hajnoczi, Li Zhijian
Cc: qemu-devel, jan.kiszka, jasowang, dgilbert, peter.huangpeng,
Gonglei (Arei), stefanha, Yang Hongyang
On 2015/7/20 18:32, Stefan Hajnoczi wrote:
> On Mon, Jul 20, 2015 at 02:42:33PM +0800, Li Zhijian wrote:
>> We are planning to implement colo-proxy in qemu to cache and compare packets.
>
> I thought there is a kernel module to do that?
>
Yes, but we decided to re-implement it in userspace (Here is in qemu),
there are mainly two reasons that we made this change. One is the colo-proxy in kernel is
narrowly used, which can only be used for COLO FT, besides, we have to modify iptables and nftables
to support this capability. IMHO, it is hardly been accepted by the kernel community.
The other reason is that the kernel proxy scenario can't been used in all situations, for example,
evs + vhost-user + dpdk, it can't work if VM's network packets don't go through host's network
stack. (For the new userspace colo proxy scheme, we also can't use it with vhost-net,
we have to use virtio-net instead).
> Why does the proxy need to be part of the QEMU process? -netdev socket
> or host network stack features allow you to process packets in a
> separate process.
>
> Without details on what the proxy does it's hard to discuss this. What
> happens in the non-TCP case? What happens in the TCP case?
>
> Does the proxy need to perform privileged operations, create sockets,
> open files, etc?
>
> The slirp code is not actively developed or used much in production. It
> might be a good idea to audit the code for bugs if you want to use it.
>
Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
have to supplement it.
Thanks,
zhanghailiang
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-20 11:55 ` zhanghailiang
@ 2015-07-20 13:12 ` Vasiliy Tolstov
2015-07-20 15:01 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Vasiliy Tolstov @ 2015-07-20 13:12 UTC (permalink / raw)
To: zhanghailiang
Cc: Li Zhijian, Stefan Hajnoczi, jasowang, dgilbert, qemu-devel,
Gonglei (Arei), stefanha, jan.kiszka, peter.huangpeng,
Yang Hongyang
2015-07-20 14:55 GMT+03:00 zhanghailiang <zhang.zhanghailiang@huawei.com>:
> Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
> have to supplement it.
patch for ipv6 slirp support some times ago sended to qemu list, but i
don't know why in not accepted.
--
Vasiliy Tolstov,
e-mail: v.tolstov@selfip.ru
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-20 13:12 ` Vasiliy Tolstov
@ 2015-07-20 15:01 ` Stefan Hajnoczi
2015-07-21 6:13 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-07-20 15:01 UTC (permalink / raw)
To: J. Kiszka
Cc: zhanghailiang, Li Zhijian, Jason Wang, Dave Gilbert,
Vasiliy Tolstov, qemu-devel, Gonglei (Arei), Stefan Hajnoczi,
Huangpeng (Peter), Yang Hongyang
On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov <v.tolstov@selfip.ru> wrote:
> 2015-07-20 14:55 GMT+03:00 zhanghailiang <zhang.zhanghailiang@huawei.com>:
>> Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
>> have to supplement it.
>
>
> patch for ipv6 slirp support some times ago sended to qemu list, but i
> don't know why in not accepted.
I think no one reviewed it but there was no objection against IPv6
support in principle.
Jan: Can we merge slirp IPv6 support for QEMU 2.5?
Stefan
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-20 15:01 ` Stefan Hajnoczi
@ 2015-07-21 6:13 ` Jan Kiszka
2015-07-21 9:49 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2015-07-21 6:13 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: zhanghailiang, Li Zhijian, Jason Wang, Dave Gilbert,
Vasiliy Tolstov, qemu-devel, Gonglei (Arei), Stefan Hajnoczi,
Huangpeng (Peter), Yang Hongyang
On 2015-07-20 17:01, Stefan Hajnoczi wrote:
> On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov <v.tolstov@selfip.ru> wrote:
>> 2015-07-20 14:55 GMT+03:00 zhanghailiang <zhang.zhanghailiang@huawei.com>:
>>> Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
>>> have to supplement it.
>>
>>
>> patch for ipv6 slirp support some times ago sended to qemu list, but i
>> don't know why in not accepted.
>
> I think no one reviewed it but there was no objection against IPv6
> support in principle.
>
> Jan: Can we merge slirp IPv6 support for QEMU 2.5?
Sorry, as I pointed out some time back, I don't have the bandwidth to
look into slirp. Someone need to do a review, then send a pull request.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-21 6:13 ` Jan Kiszka
@ 2015-07-21 9:49 ` Stefan Hajnoczi
2015-07-27 10:13 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-07-21 9:49 UTC (permalink / raw)
To: Jan Kiszka
Cc: zhanghailiang, Li Zhijian, Stefan Hajnoczi, Jason Wang,
qemu-devel, Vasiliy Tolstov, Dave Gilbert, Gonglei (Arei),
Huangpeng (Peter), Yang Hongyang
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On Tue, Jul 21, 2015 at 08:13:42AM +0200, Jan Kiszka wrote:
> On 2015-07-20 17:01, Stefan Hajnoczi wrote:
> > On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov <v.tolstov@selfip.ru> wrote:
> >> 2015-07-20 14:55 GMT+03:00 zhanghailiang <zhang.zhanghailiang@huawei.com>:
> >>> Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
> >>> have to supplement it.
> >>
> >>
> >> patch for ipv6 slirp support some times ago sended to qemu list, but i
> >> don't know why in not accepted.
> >
> > I think no one reviewed it but there was no objection against IPv6
> > support in principle.
> >
> > Jan: Can we merge slirp IPv6 support for QEMU 2.5?
>
> Sorry, as I pointed out some time back, I don't have the bandwidth to
> look into slirp. Someone need to do a review, then send a pull request.
Do you want to remove yourself from the slirp section of the MAINTAINERS
file?
Going forward we'll need to find someone familiar with the QEMU
development process and with enough time to review slirp patches.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-21 9:49 ` Stefan Hajnoczi
@ 2015-07-27 10:13 ` Stefan Hajnoczi
2015-07-27 13:33 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-07-27 10:13 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: zhanghailiang, Li Zhijian, Jan Kiszka, Jason Wang, qemu-devel,
Vasiliy Tolstov, Dave Gilbert, Gonglei (Arei), Huangpeng (Peter),
Yang Hongyang
[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]
On Tue, Jul 21, 2015 at 10:49:29AM +0100, Stefan Hajnoczi wrote:
> On Tue, Jul 21, 2015 at 08:13:42AM +0200, Jan Kiszka wrote:
> > On 2015-07-20 17:01, Stefan Hajnoczi wrote:
> > > On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov <v.tolstov@selfip.ru> wrote:
> > >> 2015-07-20 14:55 GMT+03:00 zhanghailiang <zhang.zhanghailiang@huawei.com>:
> > >>> Agreed, besides, it is seemed that slirp is not supporting ipv6, we also
> > >>> have to supplement it.
> > >>
> > >>
> > >> patch for ipv6 slirp support some times ago sended to qemu list, but i
> > >> don't know why in not accepted.
> > >
> > > I think no one reviewed it but there was no objection against IPv6
> > > support in principle.
> > >
> > > Jan: Can we merge slirp IPv6 support for QEMU 2.5?
> >
> > Sorry, as I pointed out some time back, I don't have the bandwidth to
> > look into slirp. Someone need to do a review, then send a pull request.
>
> Do you want to remove yourself from the slirp section of the MAINTAINERS
> file?
>
> Going forward we'll need to find someone familiar with the QEMU
> development process and with enough time to review slirp patches.
Ping?
I hoped this would raise some discussion and that maybe we could find a
new maintainer or co-maintainer to get slirp moving.
Any thoughts?
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-27 10:13 ` Stefan Hajnoczi
@ 2015-07-27 13:33 ` Jan Kiszka
2015-07-28 22:12 ` Samuel Thibault
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2015-07-27 13:33 UTC (permalink / raw)
To: Stefan Hajnoczi, Stefan Hajnoczi, Samuel Thibault
Cc: zhanghailiang, Li Zhijian, Jason Wang, Dave Gilbert,
Vasiliy Tolstov, qemu-devel, Gonglei (Arei), Huangpeng (Peter),
Yang Hongyang
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 2015-07-27 12:13, Stefan Hajnoczi wrote:
> On Tue, Jul 21, 2015 at 10:49:29AM +0100, Stefan Hajnoczi wrote:
>> On Tue, Jul 21, 2015 at 08:13:42AM +0200, Jan Kiszka wrote:
>>> On 2015-07-20 17:01, Stefan Hajnoczi wrote:
>>>> On Mon, Jul 20, 2015 at 2:12 PM, Vasiliy Tolstov
>>>> <v.tolstov@selfip.ru> wrote:
>>>>> 2015-07-20 14:55 GMT+03:00 zhanghailiang
>>>>> <zhang.zhanghailiang@huawei.com>:
>>>>>> Agreed, besides, it is seemed that slirp is not
>>>>>> supporting ipv6, we also have to supplement it.
>>>>>
>>>>>
>>>>> patch for ipv6 slirp support some times ago sended to qemu
>>>>> list, but i don't know why in not accepted.
>>>>
>>>> I think no one reviewed it but there was no objection against
>>>> IPv6 support in principle.
>>>>
>>>> Jan: Can we merge slirp IPv6 support for QEMU 2.5?
>>>
>>> Sorry, as I pointed out some time back, I don't have the
>>> bandwidth to look into slirp. Someone need to do a review, then
>>> send a pull request.
>>
>> Do you want to remove yourself from the slirp section of the
>> MAINTAINERS file?
>>
>> Going forward we'll need to find someone familiar with the QEMU
>> development process and with enough time to review slirp
>> patches.
>
> Ping?
>
> I hoped this would raise some discussion and that maybe we could
> find a new maintainer or co-maintainer to get slirp moving.
>
> Any thoughts?
Of course, I'm fine with handing this over to someone who'd like to
pick up. Do we have volunteers?
Samuel, would you like to do this? As a subsystem maintainer, you are
already familiar with QEMU processes. Well, this still wouldn't
resolve the independent review need for slirp-ipv6.
Jan
- --
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iEYEARECAAYFAlW2MycACgkQitSsb3rl5xSCaACePNubKPBkrdxQkcThUGD7w56B
Q6oAoIgCzT9qVRzDf5IhY2eKFXgTZ+Ul
=yk6R
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-27 13:33 ` Jan Kiszka
@ 2015-07-28 22:12 ` Samuel Thibault
2015-07-29 7:36 ` Jan Kiszka
0 siblings, 1 reply; 8+ messages in thread
From: Samuel Thibault @ 2015-07-28 22:12 UTC (permalink / raw)
To: Jan Kiszka
Cc: zhanghailiang, Li Zhijian, Stefan Hajnoczi, Jason Wang,
qemu-devel, Vasiliy Tolstov, Dave Gilbert, Gonglei (Arei),
Stefan Hajnoczi, Huangpeng (Peter), Yang Hongyang
Hello,
Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> Of course, I'm fine with handing this over to someone who'd like to
> pick up. Do we have volunteers?
>
> Samuel, would you like to do this? As a subsystem maintainer, you are
> already familiar with QEMU processes.
I can help with maintenance, yes.
> Well, this still wouldn't resolve the independent review need for
> slirp-ipv6.
Well, actually I didn't write slirp-ipv6, Guillaume Subiron did, and I
reviewed it (and we iterated quite a bit) before we submit the patch
series to qemu-devel.
Samuel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [POC] colo-proxy in qemu
2015-07-28 22:12 ` Samuel Thibault
@ 2015-07-29 7:36 ` Jan Kiszka
2015-07-29 9:33 ` [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
0 siblings, 1 reply; 8+ messages in thread
From: Jan Kiszka @ 2015-07-29 7:36 UTC (permalink / raw)
To: Samuel Thibault
Cc: zhanghailiang, Li Zhijian, Stefan Hajnoczi, Jason Wang,
qemu-devel, Vasiliy Tolstov, Dave Gilbert, Gonglei (Arei),
Stefan Hajnoczi, Huangpeng (Peter), Yang Hongyang
On 2015-07-29 00:12, Samuel Thibault wrote:
> Hello,
>
> Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
>> Of course, I'm fine with handing this over to someone who'd like to
>> pick up. Do we have volunteers?
>>
>> Samuel, would you like to do this? As a subsystem maintainer, you are
>> already familiar with QEMU processes.
>
> I can help with maintenance, yes.
"Help with" will easily mean "be the one and only". ;) If you prefer,
send a patch which only adds you as a maintainer, but I would also ack
one that drops me from the list as well.
>
>> Well, this still wouldn't resolve the independent review need for
>> slirp-ipv6.
>
> Well, actually I didn't write slirp-ipv6, Guillaume Subiron did, and I
> reviewed it (and we iterated quite a bit) before we submit the patch
> series to qemu-devel.
Perfekt!
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-07-29 7:36 ` Jan Kiszka
@ 2015-07-29 9:33 ` Samuel Thibault
2015-08-06 10:10 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Samuel Thibault @ 2015-07-29 9:33 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
---
Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> On 2015-07-29 00:12, Samuel Thibault wrote:
> > Hello,
> >
> > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> >> Of course, I'm fine with handing this over to someone who'd like to
> >> pick up. Do we have volunteers?
> >>
> >> Samuel, would you like to do this? As a subsystem maintainer, you are
> >> already familiar with QEMU processes.
> >
> > I can help with maintenance, yes.
>
> "Help with" will easily mean "be the one and only". ;)
Right, I understand that :) That's still preferable to have two contact
people.
diff --git a/MAINTAINERS b/MAINTAINERS
index 978b717..b506df5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1018,6 +1018,7 @@ F: scripts/qmp/
T: git git://repo.or.cz/qemu/armbru.git qapi-next
SLIRP
+M: Samuel Thibault <samuel.thibault@ens-lyon.org>
M: Jan Kiszka <jan.kiszka@siemens.com>
S: Maintained
F: slirp/
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-07-29 9:33 ` [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
@ 2015-08-06 10:10 ` Stefan Hajnoczi
2015-08-06 12:29 ` Fam Zheng
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-08-06 10:10 UTC (permalink / raw)
To: Samuel Thibault; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]
On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> ---
> Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> > On 2015-07-29 00:12, Samuel Thibault wrote:
> > > Hello,
> > >
> > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> > >> Of course, I'm fine with handing this over to someone who'd like to
> > >> pick up. Do we have volunteers?
> > >>
> > >> Samuel, would you like to do this? As a subsystem maintainer, you are
> > >> already familiar with QEMU processes.
> > >
> > > I can help with maintenance, yes.
> >
> > "Help with" will easily mean "be the one and only". ;)
>
> Right, I understand that :) That's still preferable to have two contact
> people.
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 978b717..b506df5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1018,6 +1018,7 @@ F: scripts/qmp/
> T: git git://repo.or.cz/qemu/armbru.git qapi-next
>
> SLIRP
> +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
> M: Jan Kiszka <jan.kiszka@siemens.com>
> S: Maintained
> F: slirp/
Please resend as a top-level email.
If you send patches as a reply to a thread they are easy to miss.
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-08-06 10:10 ` Stefan Hajnoczi
@ 2015-08-06 12:29 ` Fam Zheng
2015-08-07 10:19 ` Stefan Hajnoczi
0 siblings, 1 reply; 8+ messages in thread
From: Fam Zheng @ 2015-08-06 12:29 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Samuel Thibault, qemu-devel
On Thu, 08/06 11:10, Stefan Hajnoczi wrote:
> On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> >
> > ---
> > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
> > > On 2015-07-29 00:12, Samuel Thibault wrote:
> > > > Hello,
> > > >
> > > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
> > > >> Of course, I'm fine with handing this over to someone who'd like to
> > > >> pick up. Do we have volunteers?
> > > >>
> > > >> Samuel, would you like to do this? As a subsystem maintainer, you are
> > > >> already familiar with QEMU processes.
> > > >
> > > > I can help with maintenance, yes.
> > >
> > > "Help with" will easily mean "be the one and only". ;)
> >
> > Right, I understand that :) That's still preferable to have two contact
> > people.
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 978b717..b506df5 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1018,6 +1018,7 @@ F: scripts/qmp/
> > T: git git://repo.or.cz/qemu/armbru.git qapi-next
> >
> > SLIRP
> > +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > M: Jan Kiszka <jan.kiszka@siemens.com>
> > S: Maintained
> > F: slirp/
>
> Please resend as a top-level email.
This email has proper subject, sign-off line and patch format, and the header
doesn't have "In-reply-to". So it makes a legit patch. The quotes are below the
"---" line so it should be read as complementary information and I think it is
totally fine. At least patchew treats it so :)
http://qemu.patchew.org/series/%3C20150806111014.GA6432%40type.bordeaux.inria.fr%3E
Therefore,
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-08-06 12:29 ` Fam Zheng
@ 2015-08-07 10:19 ` Stefan Hajnoczi
2015-08-07 10:34 ` Fam Zheng
0 siblings, 1 reply; 8+ messages in thread
From: Stefan Hajnoczi @ 2015-08-07 10:19 UTC (permalink / raw)
To: Fam Zheng; +Cc: Samuel Thibault, qemu-devel
On Thu, Aug 6, 2015 at 1:29 PM, Fam Zheng <famz@redhat.com> wrote:
> On Thu, 08/06 11:10, Stefan Hajnoczi wrote:
>> On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote:
>> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> >
>> > ---
>> > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit :
>> > > On 2015-07-29 00:12, Samuel Thibault wrote:
>> > > > Hello,
>> > > >
>> > > > Jan Kiszka, le Mon 27 Jul 2015 15:33:27 +0200, a écrit :
>> > > >> Of course, I'm fine with handing this over to someone who'd like to
>> > > >> pick up. Do we have volunteers?
>> > > >>
>> > > >> Samuel, would you like to do this? As a subsystem maintainer, you are
>> > > >> already familiar with QEMU processes.
>> > > >
>> > > > I can help with maintenance, yes.
>> > >
>> > > "Help with" will easily mean "be the one and only". ;)
>> >
>> > Right, I understand that :) That's still preferable to have two contact
>> > people.
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 978b717..b506df5 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -1018,6 +1018,7 @@ F: scripts/qmp/
>> > T: git git://repo.or.cz/qemu/armbru.git qapi-next
>> >
>> > SLIRP
>> > +M: Samuel Thibault <samuel.thibault@ens-lyon.org>
>> > M: Jan Kiszka <jan.kiszka@siemens.com>
>> > S: Maintained
>> > F: slirp/
>>
>> Please resend as a top-level email.
>
> This email has proper subject, sign-off line and patch format, and the header
> doesn't have "In-reply-to".
It is definitely a reply rather than a top-level post. Here is what
the headers look like here:
Delivered-To: stefanha@gmail.com
Date: Wed, 29 Jul 2015 11:33:26 +0200
From: Samuel Thibault <samuel.thibault@gnu.org>
To: qemu-devel <qemu-devel@nongnu.org>
Message-ID: <20150729093326.GG2979@type.bordeaux.inria.fr>
References: <20150720103208.GA12675@stefanha-thinkpad.redhat.com>
<55ACE1B4.4010109@huawei.com>
<CACaajQsMGGuxTrOYb0AYF_Vv7kzOztn_Phi4TEKtfWPEEkfRyg@mail.gmail.com>
<CAJSP0QWw8SyENL=eMpFstxr9kG038CVs5GKY3qZ+V1foxDmykg@mail.gmail.com>
<55ADE316.1060704@siemens.com>
<20150721094929.GD13993@stefanha-thinkpad.redhat.com>
<20150727101305.GD30018@stefanha-thinkpad.redhat.com>
<55B63327.5080205@siemens.com> <20150728221234.GI3467@type.home>
<55B8826F.1090305@siemens.com>
In-Reply-To: <55B8826F.1090305@siemens.com>
Subject: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp
maintainer
...
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer
2015-08-07 10:19 ` Stefan Hajnoczi
@ 2015-08-07 10:34 ` Fam Zheng
0 siblings, 0 replies; 8+ messages in thread
From: Fam Zheng @ 2015-08-07 10:34 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Samuel Thibault, qemu-devel
On Fri, 08/07 11:19, Stefan Hajnoczi wrote:
> It is definitely a reply rather than a top-level post. Here is what
> the headers look like here:
>
> Delivered-To: stefanha@gmail.com
> Date: Wed, 29 Jul 2015 11:33:26 +0200
> From: Samuel Thibault <samuel.thibault@gnu.org>
> To: qemu-devel <qemu-devel@nongnu.org>
> Message-ID: <20150729093326.GG2979@type.bordeaux.inria.fr>
> References: <20150720103208.GA12675@stefanha-thinkpad.redhat.com>
> <55ACE1B4.4010109@huawei.com>
> <CACaajQsMGGuxTrOYb0AYF_Vv7kzOztn_Phi4TEKtfWPEEkfRyg@mail.gmail.com>
> <CAJSP0QWw8SyENL=eMpFstxr9kG038CVs5GKY3qZ+V1foxDmykg@mail.gmail.com>
> <55ADE316.1060704@siemens.com>
> <20150721094929.GD13993@stefanha-thinkpad.redhat.com>
> <20150727101305.GD30018@stefanha-thinkpad.redhat.com>
> <55B63327.5080205@siemens.com> <20150728221234.GI3467@type.home>
> <55B8826F.1090305@siemens.com>
> In-Reply-To: <55B8826F.1090305@siemens.com>
> Subject: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp
> maintainer
> ...
>
Oh you're right! I misread it and my email client displayed as a top level post
too, no idea why...
Fam
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-03-07 12:14 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-06 11:10 [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
2015-08-10 10:18 ` Stefan Hajnoczi
2016-03-07 12:14 ` Jan Kiszka
-- strict thread matches above, loose matches on Subject: below --
2015-07-20 10:32 [Qemu-devel] [POC] colo-proxy in qemu Stefan Hajnoczi
2015-07-20 11:55 ` zhanghailiang
2015-07-20 13:12 ` Vasiliy Tolstov
2015-07-20 15:01 ` Stefan Hajnoczi
2015-07-21 6:13 ` Jan Kiszka
2015-07-21 9:49 ` Stefan Hajnoczi
2015-07-27 10:13 ` Stefan Hajnoczi
2015-07-27 13:33 ` Jan Kiszka
2015-07-28 22:12 ` Samuel Thibault
2015-07-29 7:36 ` Jan Kiszka
2015-07-29 9:33 ` [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer Samuel Thibault
2015-08-06 10:10 ` Stefan Hajnoczi
2015-08-06 12:29 ` Fam Zheng
2015-08-07 10:19 ` Stefan Hajnoczi
2015-08-07 10:34 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).