From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56728)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZOmzT-0006EO-8I
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 09:19:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZOmzQ-0004eV-2c
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 09:19:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40548)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1ZOmzP-0004eJ-TA
	for qemu-devel@nongnu.org; Mon, 10 Aug 2015 09:19:43 -0400
Date: Mon, 10 Aug 2015 14:19:39 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20150810131939.GJ10566@redhat.com>
References: <1439212541-16997-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1439212541-16997-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] error: only prepend timestamp on stderr
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Frank Schreuder <fschreuder@transip.nl>, Seiji Aguchi <seiji.aguchi@hds.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Mon, Aug 10, 2015 at 02:15:41PM +0100, Stefan Hajnoczi wrote:
> The -msg timestamp=on option prepends a timestamp to error messages.
> This is useful on stderr where it allows users to identify when an error
> was raised.
> 
> Timestamps do not make sense on the monitor since error_report() is
> called in response to a synchronous monitor command and the user already
> knows "when" the command was issued.  Additionally, the rest of the
> monitor conversation lacks timestamps so the error timestamp cannot be
> correlated with other activity.
> 
> Only prepend timestamps on stderr.  This fixes libvirt's 'drive_del'
> processing, which did not expect a timestamp.  Other QEMU monitor
> clients are probably equally confused by timestamps on monitor error
> messages.
> 
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Seiji Aguchi <seiji.aguchi@hds.com>
> Cc: Frank Schreuder <fschreuder@transip.nl>
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  util/qemu-error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|