From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Victor Kaplansky" <victork@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.
Date: Mon, 10 Aug 2015 13:21:52 +0300 [thread overview]
Message-ID: <20150810132141-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <CAFEAcA8wz62KMtigzJsh3FS_K65V2gCEAYwxbvPD8K2nvhTsWA@mail.gmail.com>
On Mon, Aug 10, 2015 at 11:14:50AM +0100, Peter Maydell wrote:
> On 9 August 2015 at 13:20, Michael S. Tsirkin <mst@redhat.com> wrote:
> > Still - just corious about the motivation.
> > Extra whitespace in input -> extra whitespace in output, should
> > be harmless in both cases, should it not?
>
> Yeah, I agree that it's generally harmless. My rationale for
> preferring no-space-after-comma is that it's less misleading:
> if you're used to other languages where space-after-comma has
> no meaning at all, then it's easy to think that the two are
> identical when they're not.
>
> End-of-line-continuations are I think slightly different
> because the fact that the space remains in the result is
> a bit more obvious (the continuation just folds things).
>
> -- PMM
Fair enough, thanks for the clarification.
next prev parent reply other threads:[~2015-08-10 10:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-09 9:39 [Qemu-devel] [PATCH v3 0/2] make: Cleanup and fix of loading of dependency info Victor Kaplansky
2015-08-09 9:39 ` [Qemu-devel] [PATCH v3 1/2] make: fix where dependency *.d are stored Victor Kaplansky
2015-08-09 9:39 ` [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files Victor Kaplansky
2015-08-09 11:39 ` Michael S. Tsirkin
2015-08-09 11:54 ` Peter Maydell
2015-08-09 12:20 ` Michael S. Tsirkin
2015-08-10 10:14 ` Peter Maydell
2015-08-10 10:21 ` Michael S. Tsirkin [this message]
2015-08-10 9:46 ` Victor Kaplansky
2015-08-09 11:40 ` [Qemu-devel] [PATCH v3 0/2] make: Cleanup and fix of loading of dependency info Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810132141-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=victork@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).