From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOmAG-0004CE-GH for qemu-devel@nongnu.org; Mon, 10 Aug 2015 08:26:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZOmAC-0001AC-FA for qemu-devel@nongnu.org; Mon, 10 Aug 2015 08:26:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:48749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZOmAC-00019u-51 for qemu-devel@nongnu.org; Mon, 10 Aug 2015 08:26:48 -0400 Date: Mon, 10 Aug 2015 14:26:44 +0200 From: Jean Delvare Message-ID: <20150810142644.43053dd0@endymion.delvare> In-Reply-To: <55C891E7.8050003@redhat.com> References: <1438063215-4117-1-git-send-email-wei@redhat.com> <55C244D5.3040004@redhat.com> <55C25764.9090302@redhat.com> <55C2668D.8040008@linaro.org> <20150806000347.60ea25e6@endymion.delvare> <55C315CC.4070503@redhat.com> <20150810094300.4fb50dad@endymion.delvare> <55C891E7.8050003@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] dmidecode repository (Was: [ARM SMBIOS V1 PATCH 0/6] SMBIOS Support for ARM) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Wei Huang , Peter Maydell , Andrew Jones , Eduardo Habkost , Ivan Khoronzhuk , "Michael S. Tsirkin" , "Gabriel L. Somlo" , Ard Biesheuvel , Shannon Zhao , QEMU Developers , Roy Franz , Igor Mammedov , Paolo Bonzini , Richard Henderson Hi Laszlo, On Mon, 10 Aug 2015 13:58:31 +0200, Laszlo Ersek wrote: > On 08/10/15 09:43, Jean Delvare wrote: > > OK, I think I came up with something that looks reasonably good: > > > > http://git.savannah.gnu.org/cgit/dmidecode.git > > > > Can anyone please check it out and verify that it looks sane and can be > > worked with? > > I cloned it and built it with "make". (That's all the "testing" I did. :)) Thanks for testing and reporting. > Ideas: > - please consider tagging commits that correspond to releases The conversion already did exactly that as far as I can see: dmidecode$ git tag dmidecode-1-8 dmidecode-2-0 dmidecode-2-1 dmidecode-2-10 dmidecode-2-11 dmidecode-2-12 dmidecode-2-2 dmidecode-2-3 dmidecode-2-4 dmidecode-2-5 dmidecode-2-6 dmidecode-2-7 dmidecode-2-8 dmidecode-2-9 And the tags appear in the web frontend too so my attempt to push them there must have worked. > - probably useful to tag the git commit somehow that marks the switch > from CVS to git (eg. "last_patch_from_cvs"). The conversion guide suggested tagging the cvs repository and I intend to do so. But tagging the git repository seems like adding noise to me, I can't see why anybody should care about the migration point. > - after building, "git status" lists the *.o files and the built > binaries as untracked files. For the former, please add a .gitignore > file. For the latter, please list them individually in .gitignore too, > or else build things in a separate directory, and ignore everything > inside that directory. I had noticed too and that was on my to-do list. Now this is done, thanks for the reminder. Please pull again and "git status" should be quiet now. > > If it's OK then I'll tag the CVS repository as deprecated. > > If you can ascertain that the latest tree in git (at > "last_patch_from_cvs") matches the latest tree in CVS (with a recursive > diff excluding the SCM meta-dirs), there's no reason to delay switching I already did that comparison and the result is positive. > to git. If you realize later that something's "wrong", you can format > the new patches from git and reapply them to CVS. (But I don't expect > anything to go wrong.) I am more worried about the history being incorrect, due to incorrect or missing options during the conversion. That being said, the history of dmidecode is very simple (which is why I did not bother switching to git so far) so hopefully the basic settings were good enough. -- Jean Delvare SUSE L3 Support