From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52500) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPDFb-0001uk-KG for qemu-devel@nongnu.org; Tue, 11 Aug 2015 13:22:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPDFY-0006SE-Cp for qemu-devel@nongnu.org; Tue, 11 Aug 2015 13:22:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPDFY-0006SA-88 for qemu-devel@nongnu.org; Tue, 11 Aug 2015 13:22:08 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id EB0928E500 for ; Tue, 11 Aug 2015 17:22:07 +0000 (UTC) Date: Tue, 11 Aug 2015 18:22:04 +0100 From: "Daniel P. Berrange" Message-ID: <20150811172204.GN19953@redhat.com> References: <1439303203-15999-1-git-send-email-berrange@redhat.com> <1439303203-15999-6-git-send-email-berrange@redhat.com> <55CA2672.80006@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <55CA2672.80006@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 5/5] ui: convert VNC server to use QCryptoTLSSession Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Gerd Hoffmann On Tue, Aug 11, 2015 at 06:44:34PM +0200, Paolo Bonzini wrote: > > > On 11/08/2015 16:26, Daniel P. Berrange wrote: > > -object tls-creds,id=tls0,credtype=anon,endpoint=server \ > > -vnc hostname:0,tls-creds=tls0 > > > > Old syntax for x509 credentials, no client certs: > > > > -vnc hostname:0,tls,x509=/path/to/certs > > > > New syntax: > > > > -object tls-creds,id=tls0,credtype=x509,dir=/path/to/certs,endpoint=server,verify-peer=no \ > > -vnc hostname:0,tls-creds=tls0 > > > > Old syntax for x509 credentials, requiring client certs: > > > > -vnc hostname:0,tls,x509verify=/path/to/certs > > Would it be possible to change credtype=foo to subclasses of the > abstract tls-creds class? That is > > -object tls-creds-anon,id=tls0,endpoint=server > -object tls-creds-x509,id=tls0,dir=/path/to/certs,endpoint=server,verify-peer=yes|no > > This would be more similar to how -object is usually used. You > get to choose whether to keep the union or have separate structs > QCryptoTLSCredsX509 and QCryptoTLSCredsAnonymous. Yeah that would work too. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|