From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPX2m-0005xX-Ma for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:30:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPX2g-00061u-6c for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:30:16 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:51209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPX2f-00061f-W4 for qemu-devel@nongnu.org; Wed, 12 Aug 2015 10:30:10 -0400 Date: Wed, 12 Aug 2015 10:29:59 -0400 From: Konrad Rzeszutek Wilk Message-ID: <20150812142959.GF17002@l.oracle.com> References: <1438740141-19905-1-git-send-email-feng.wu@intel.com> <55CB0AD30200007800099EFD@prv-mh.provo.novell.com> <55CB234B0200007800099F99@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit bar with more than 4G size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Wu, Feng" Cc: "xen-devel@lists.xensource.com" , "qemu-devel@nongnu.org" , Jan Beulich , "stefano.stabellini@eu.citrix.com" On Wed, Aug 12, 2015 at 08:53:44AM +0000, Wu, Feng wrote: > > > > -----Original Message----- > > From: Jan Beulich [mailto:JBeulich@suse.com] > > Sent: Wednesday, August 12, 2015 4:43 PM > > To: Wu, Feng > > Cc: stefano.stabellini@eu.citrix.com; xen-devel@lists.xensource.com; > > qemu-devel@nongnu.org > > Subject: RE: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle 64-bit > > bar with more than 4G size > > > > >>> On 12.08.15 at 09:10, wrote: > > > > > > > >> -----Original Message----- > > >> From: qemu-devel-bounces+feng.wu=intel.com@nongnu.org > > >> [mailto:qemu-devel-bounces+feng.wu=intel.com@nongnu.org] On Behalf Of > > >> Jan Beulich > > >> Sent: Wednesday, August 12, 2015 2:59 PM > > >> To: Wu, Feng > > >> Cc: xen-devel@lists.xensource.com; qemu-devel@nongnu.org; > > >> stefano.stabellini@eu.citrix.com > > >> Subject: Re: [Qemu-devel] [Xen-devel] [PATCH v1] xenpt: Properly handle > > 64-bit > > >> bar with more than 4G size > > >> > > >> >>> On 05.08.15 at 04:02, wrote: > > >> > @@ -491,8 +474,9 @@ static int > > >> xen_pt_bar_reg_write(XenPCIPassthroughState *s, XenPTReg *cfg_entry, > > >> > bar_ro_mask = XEN_PT_BAR_IO_RO_MASK | (r_size - 1); > > >> > break; > > >> > case XEN_PT_BAR_FLAG_UPPER: > > >> > + r = &d->io_regions[index-1]; > > >> > > >> Perhaps worth an assert(index > 0)? > > > > > > No problem, I will add it. BTW, do you have any other comments about this > > > patch? If no, I am > > > going to send out the new version with this changes. > > > > No - everything else looks to make sense (but continues to need > > testing). > > > > I don't have such a device in hand. Can anybody who has such a device help to test this > patch? It would be highly appreciated! Um, 4GB MMIO bars? Wouldn't the Nvidia Quadro K6000 12GB GDDR do it? I am sure that Intel would be OK expensing $4K of hardware :-) > > Thanks, > Feng > > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel