From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPhMw-0002od-UA for qemu-devel@nongnu.org; Wed, 12 Aug 2015 21:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZPhMr-0001TM-C0 for qemu-devel@nongnu.org; Wed, 12 Aug 2015 21:31:46 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:50754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZPhMq-0001S8-PV for qemu-devel@nongnu.org; Wed, 12 Aug 2015 21:31:41 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 13 Aug 2015 11:31:38 +1000 Date: Thu, 13 Aug 2015 11:30:37 +1000 From: Gavin Shan Message-ID: <20150813013037.GA9791@gwshan> References: <1439190785-18908-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439190785-18908-2-git-send-email-gwshan@linux.vnet.ibm.com> <55CAA8C3.8000802@ozlabs.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55CAA8C3.8000802@ozlabs.ru> Subject: Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Peter Maydell , David Gibson , "qemu-ppc@nongnu.org" , Gavin Shan , QEMU Developers On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote: >On 08/11/2015 07:11 PM, Peter Maydell wrote: >>On 10 August 2015 at 08:13, Gavin Shan wrote: >>>The header file was introduced by following Linux upstream commits: >>> >>> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >>> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >>> >>>Signed-off-by: Gavin Shan >>>--- >>> linux-headers/asm-powerpc/eeh.h | 56 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 56 insertions(+) >>> create mode 100644 linux-headers/asm-powerpc/eeh.h >> >>Shouldn't this be added by updating scripts/update-linux-headers.sh >>and then doing a plain "synchronize headers against kernel version $X" ? > > >I also thought this is the protocol but then I looked into the git history >and discovered this is not always the case :) > > So should I use scripts/update-linux-headers.sh or what I had is fine? >>Otherwise you won't get any future changes to this file. >> Thanks, Gavin