From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQ3Wd-0000gd-9D for qemu-devel@nongnu.org; Thu, 13 Aug 2015 21:11:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQ3Wa-0003vA-DN for qemu-devel@nongnu.org; Thu, 13 Aug 2015 21:11:15 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:35874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQ3WZ-0003tG-Qx for qemu-devel@nongnu.org; Thu, 13 Aug 2015 21:11:12 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 14 Aug 2015 11:11:07 +1000 Date: Fri, 14 Aug 2015 11:10:06 +1000 From: Gavin Shan Message-ID: <20150814011006.GA20935@gwshan> References: <1439190785-18908-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439190785-18908-2-git-send-email-gwshan@linux.vnet.ibm.com> <55CAA8C3.8000802@ozlabs.ru> <20150813013037.GA9791@gwshan> <20150813014259.GB7910@voom.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150813014259.GB7910@voom.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 1/3] linux-headers: Add eeh.h Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Alexey Kardashevskiy , Peter Maydell , "qemu-ppc@nongnu.org" , Gavin Shan , QEMU Developers On Thu, Aug 13, 2015 at 11:42:59AM +1000, David Gibson wrote: >On Thu, Aug 13, 2015 at 11:30:37AM +1000, Gavin Shan wrote: >> On Wed, Aug 12, 2015 at 12:00:35PM +1000, Alexey Kardashevskiy wrote: >> >On 08/11/2015 07:11 PM, Peter Maydell wrote: >> >>On 10 August 2015 at 08:13, Gavin Shan wrote: >> >>>The header file was introduced by following Linux upstream commits: >> >>> >> >>> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >> >>> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >> >>> >> >>>Signed-off-by: Gavin Shan >> >>>--- >> >>> linux-headers/asm-powerpc/eeh.h | 56 +++++++++++++++++++++++++++++++++++++++++ >> >>> 1 file changed, 56 insertions(+) >> >>> create mode 100644 linux-headers/asm-powerpc/eeh.h >> >> >> >>Shouldn't this be added by updating scripts/update-linux-headers.sh >> >>and then doing a plain "synchronize headers against kernel version $X" ? >> > >> > >> >I also thought this is the protocol but then I looked into the git history >> >and discovered this is not always the case :) >> > >> > >> >> So should I use scripts/update-linux-headers.sh or what I had is >> fine? > >Please use update-linux-headers.sh - and make sure you also update the >script itself (if necessary) so it will pull in future updates to >eeh.h > Sure, thanks, David. It will be covered in next revision. Thanks, Gavin