From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQEVr-000336-Ll for qemu-devel@nongnu.org; Fri, 14 Aug 2015 08:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQEVm-0006Qs-Rm for qemu-devel@nongnu.org; Fri, 14 Aug 2015 08:55:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQEVm-0006Gm-MT for qemu-devel@nongnu.org; Fri, 14 Aug 2015 08:55:06 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2F434A063C for ; Fri, 14 Aug 2015 12:55:03 +0000 (UTC) Date: Fri, 14 Aug 2015 13:54:59 +0100 From: "Daniel P. Berrange" Message-ID: <20150814125459.GJ7776@redhat.com> References: <1439556435-20541-1-git-send-email-cfergeau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1439556435-20541-1-git-send-email-cfergeau@redhat.com> Subject: Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > Before commit b1ea7b79e1, it was possible to start with -spice > disable-ticketing, and then use the "set_password spice" command to > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > possible as qemu_spice_set_ticket() will return an error unless the > 'auth' type is "spice". When ticketing is disabled, 'auth' is "none" so > the attempt to set password fails. > > This commit allows to call qemu_spice_set_ticket() when 'auth' is "none" > and changes 'auth' to "spice" when this happens. IMHO we should not be changing the authentication method as a side effect of trying to set the password. If app has disabled ticketing, it should remain disabled and the set password call is right to return an error. We should have a graphics-set-auth command for changing authentication parameters on existing graphics backend. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|