From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQFbO-0001NU-6x for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:04:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQFbJ-0005UW-0k for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:04:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQFbI-0005UR-RC for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:04:52 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 5FAE037258D for ; Fri, 14 Aug 2015 14:04:52 +0000 (UTC) Date: Fri, 14 Aug 2015 15:04:48 +0100 From: "Daniel P. Berrange" Message-ID: <20150814140448.GL7776@redhat.com> References: <1439556435-20541-1-git-send-email-cfergeau@redhat.com> <20150814125459.GJ7776@redhat.com> <20150814130944.GI8732@edamame.cdg.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150814130944.GI8732@edamame.cdg.redhat.com> Subject: Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org On Fri, Aug 14, 2015 at 03:09:44PM +0200, Christophe Fergeau wrote: > Hey, > > On Fri, Aug 14, 2015 at 01:54:59PM +0100, Daniel P. Berrange wrote: > > On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > > > Before commit b1ea7b79e1, it was possible to start with -spice > > > disable-ticketing, and then use the "set_password spice" command to > > > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > > > possible as qemu_spice_set_ticket() will return an error unless the > > > 'auth' type is "spice". When ticketing is disabled, 'auth' is "none" so > > > the attempt to set password fails. > > > > > > This commit allows to call qemu_spice_set_ticket() when 'auth' is "none" > > > and changes 'auth' to "spice" when this happens. > > > > IMHO we should not be changing the authentication method as a side > > effect of trying to set the password. > > > > If app has disabled ticketing, it should remain disabled and the > > set password call is right to return an error. > > > > In general I agree with you. However in this case, this used to be > working until ~1 year ago, and this change of behaviour caused a bug in > oVirt (oVirt side is being fixed). This is why I sent this patch. > > The intent of commit b1ea7b seems to be to prevent > qemu_spice_set_passwd() from being called when SASL is used, and does > not mention at all whether preventing going from auth being "none" to > "spice" is intentional. > > If this change of behaviour was an intentional bug fix, and if we are > fine with asking for oVirt changes for this, then I'm ok with dropping > this patch. Hmm, is oVirt using this via libvirt ? If so, I guess we have to fix it, as that would be a break in current usage. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|