From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQG52-0003Zc-En for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:35:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQG4y-0002nO-Tf for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:35:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQG4y-0002nB-O2 for qemu-devel@nongnu.org; Fri, 14 Aug 2015 10:35:32 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 06097A04A6 for ; Fri, 14 Aug 2015 14:35:29 +0000 (UTC) Date: Fri, 14 Aug 2015 15:35:21 +0100 From: "Daniel P. Berrange" Message-ID: <20150814143521.GO7776@redhat.com> References: <1439556435-20541-1-git-send-email-cfergeau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1439556435-20541-1-git-send-email-cfergeau@redhat.com> Subject: Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christophe Fergeau Cc: qemu-devel@nongnu.org On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote: > Before commit b1ea7b79e1, it was possible to start with -spice > disable-ticketing, and then use the "set_password spice" command to > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer > possible as qemu_spice_set_ticket() will return an error unless the > 'auth' type is "spice". When ticketing is disabled, 'auth' is "none" so > the attempt to set password fails. > > This commit allows to call qemu_spice_set_ticket() when 'auth' is "none" > and changes 'auth' to "spice" when this happens. BTW, you need to have a Signed-of-by here > --- > ui/spice-core.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|