From: Christophe Fergeau <cfergeau@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used
Date: Fri, 14 Aug 2015 17:11:29 +0200 [thread overview]
Message-ID: <20150814151129.GC19434@edamame.cdg.redhat.com> (raw)
In-Reply-To: <20150814143521.GO7776@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
On Fri, Aug 14, 2015 at 03:35:21PM +0100, Daniel P. Berrange wrote:
> On Fri, Aug 14, 2015 at 02:47:15PM +0200, Christophe Fergeau wrote:
> > Before commit b1ea7b79e1, it was possible to start with -spice
> > disable-ticketing, and then use the "set_password spice" command to
> > enable ticketing with SPICE. Since commit b1ea7b79e1 this is no longer
> > possible as qemu_spice_set_ticket() will return an error unless the
> > 'auth' type is "spice". When ticketing is disabled, 'auth' is "none" so
> > the attempt to set password fails.
> >
> > This commit allows to call qemu_spice_set_ticket() when 'auth' is "none"
> > and changes 'auth' to "spice" when this happens.
>
> BTW, you need to have a Signed-of-by here
Ah right, thanks, just sent a v2 with this added.
Christophe
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-08-14 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 12:47 [Qemu-devel] [PATCH] spice: Allow to set password even if disable-ticketing was used Christophe Fergeau
2015-08-14 12:54 ` Daniel P. Berrange
2015-08-14 13:09 ` Christophe Fergeau
2015-08-14 14:04 ` Daniel P. Berrange
2015-08-14 14:31 ` Christophe Fergeau
2015-08-14 14:35 ` Daniel P. Berrange
2015-08-14 15:11 ` Christophe Fergeau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814151129.GC19434@edamame.cdg.redhat.com \
--to=cfergeau@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).