From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRq9e-0007Vk-Ug for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:18:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRq9a-0005A2-T3 for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:18:54 -0400 Date: Tue, 18 Aug 2015 15:53:25 -0700 From: David Gibson Message-ID: <20150818225325.GF3157@voom> References: <1439862430-14996-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439862430-14996-3-git-send-email-gwshan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TD8GDToEDw0WLGOL" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Alexey Kardashevskiy , "qemu-ppc@nongnu.org" , Gavin Shan , QEMU Developers --TD8GDToEDw0WLGOL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: > On 18 August 2015 at 02:47, Gavin Shan wrote: > > The header file was introduced by following Linux upstream commits: > > > > commit ed3e81f ("powerpc/eeh: Move PE state constants around") > > commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") > > > > Signed-off-by: Gavin Shan > > --- > > I didn't include all changes from scripts/update-linux-headers.sh > > as too many unrelated changes introduced by the script. >=20 > Please just have a commit which does a "sync linux headers > from kernel version $WHATEVER". The whole point of the script > is to keep our headers completely synchronized with the kernel. >=20 > (The only exception to this is RFC patchsets where the kernel > header changes haven't yet hit mainline.) Seconded. Please include the SHA ID of the upstream kernel you updated from in your commit message, too. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TD8GDToEDw0WLGOL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV07dkAAoJEGw4ysog2bOShykP/3wqttEnkuX+tymhrocCelgI hszep6nMXXCIGeLm1WdX6PQFnLR2BGtexU+6vTgKV/JWNBpAjwq5x/Zru1H4+3VA AFIsSLZ1dsmIw2iT2t2pi0jFIKTukXT+DJosHGUNJm/YPoF8GyJoL9FnrGLjVSr4 jJuzCK3q7yi+YpH9YDJusqVV8n4SJllJTa2jkQrFEsEN14kMQI0u3svmexY+UEEC zZbu2H4NRvrJ8IKTOPhZYVN2qie/VEEa+3pC8RkLdr9eKuf0F+dstNM9GEYs0t9D yA5g4hu02gU0nAXQ7Elw8YMzoLvS8IhqWQ+6Uiy8nG2BsBsTOBVknd0wg/4qNwrT SdCtsP8qDJVbcPXAx1HuG0gTZZ33/215xecwkVv/Fnfj9TQUIHZ06CD33Rycn4px 7lDTN9b/POtr2Xf7M37EQQutCg/oIXRshMnPETw/6X0qDpTr9iuNZKavuAvQu2Df /dsJTRI8YmITOdkxTiiGARdKPbr5uGobbdq8pb8p2e2SxRWMqmhIH7EgFikKbeUG PPBlFAfASqV+GwyEbBOb7C1RLLGA9KNhwShWRSz3gB3hksSH8uASutp6aau0GrPA dRMxA09/yet/moeilA0LQTNHzvB9+APpaIPvZzwo+iyJIPO5EEHp3kC1CMhk23Mu +Ramq2LDKHXhh33UEsJU =7AhO -----END PGP SIGNATURE----- --TD8GDToEDw0WLGOL--