From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqXn-0001HN-AZ for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:43:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZRqXj-0002EP-9d for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:43:51 -0400 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:44567) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZRqXi-0002DA-Lo for qemu-devel@nongnu.org; Tue, 18 Aug 2015 19:43:47 -0400 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Aug 2015 09:43:43 +1000 Date: Wed, 19 Aug 2015 09:42:40 +1000 From: Gavin Shan Message-ID: <20150818234240.GA8064@gwshan> References: <1439862430-14996-1-git-send-email-gwshan@linux.vnet.ibm.com> <1439862430-14996-3-git-send-email-gwshan@linux.vnet.ibm.com> <20150818225325.GF3157@voom> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150818225325.GF3157@voom> Subject: Re: [Qemu-devel] [PATCH v5 2/4] linux-headers: Add eeh.h Reply-To: Gavin Shan List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: Alexey Kardashevskiy , Peter Maydell , "qemu-ppc@nongnu.org" , Gavin Shan , QEMU Developers On Tue, Aug 18, 2015 at 03:53:25PM -0700, David Gibson wrote: >On Tue, Aug 18, 2015 at 01:26:39PM +0100, Peter Maydell wrote: >> On 18 August 2015 at 02:47, Gavin Shan wrote: >> > The header file was introduced by following Linux upstream commits: >> > >> > commit ed3e81f ("powerpc/eeh: Move PE state constants around") >> > commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >> > >> > Signed-off-by: Gavin Shan >> > --- >> > I didn't include all changes from scripts/update-linux-headers.sh >> > as too many unrelated changes introduced by the script. >> >> Please just have a commit which does a "sync linux headers >> from kernel version $WHATEVER". The whole point of the script >> is to keep our headers completely synchronized with the kernel. >> >> (The only exception to this is RFC patchsets where the kernel >> header changes haven't yet hit mainline.) > >Seconded. Please include the SHA ID of the upstream kernel you >updated from in your commit message, too. > Ok. I'll do. Thanks! >-- >David Gibson | I'll have my music baroque, and my code >david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ > | _way_ _around_! >http://www.ozlabs.org/~dgibson