From: Fam Zheng <famz@redhat.com>
To: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>,
stefanha@redhat.com
Cc: Dmitry Fleytman <dmitry@daynix.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated
Date: Thu, 20 Aug 2015 02:45:47 +0800 [thread overview]
Message-ID: <20150819184547.GA6800@dhcp-15-192.nay.redhat.com> (raw)
In-Reply-To: <1439897142-28072-1-git-send-email-shmulik.ladkani@ravellosystems.com>
On Tue, 08/18 14:25, Shmulik Ladkani wrote:
> As of a90a7425cf592a3afeff3eaf32f543b83050ee5c 'tap: Drop tap_can_send'
> vmxnet3 (with tap networking) can no longer receive once device is
> deactivated.
> Alas, as the device is initially "inactive", this brakes vmxnet3
> receive functionality.
>
> vmxnet3_can_receive() checks its internal 'device_active' flag (among
> other tests).
> However, as of a90a7425cf, if 'device_active' is false, packets will be
> queued by tap_send (at qemu_net_queue_send).
>
> However, vmxnet3 never flushes the queue, even if the device is later
> activated.
>
> Fix by calling 'qemu_flush_queued_packets()' when vmxnet3 device gets
> active.
>
> Signed-off-by: Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Looks like the previous patch to fix this fell between the cracks and never
made it to qemu.git?
http://patchwork.ozlabs.org/patch/489847/
Stefan, any idea?
Fam
next prev parent reply other threads:[~2015-08-19 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 11:25 [Qemu-devel] [PATCH] net/vmxnet3: Flush packets when device gets activated Shmulik Ladkani
2015-08-19 17:32 ` Dmitry Fleytman
2015-08-19 18:45 ` Fam Zheng [this message]
2015-09-02 13:48 ` Stefan Hajnoczi
2015-09-04 7:12 ` Shmulik Ladkani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819184547.GA6800@dhcp-15-192.nay.redhat.com \
--to=famz@redhat.com \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=shmulik.ladkani@ravellosystems.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).