From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive
Date: Thu, 20 Aug 2015 02:52:02 +0800 [thread overview]
Message-ID: <20150819185202.GA8816@dhcp-15-192.nay.redhat.com> (raw)
In-Reply-To: <20150703104138.GA15942@stefanha-thinkpad.redhat.com>
On Fri, 07/03 11:41, Stefan Hajnoczi wrote:
> On Fri, Jul 03, 2015 at 09:08:41AM +0800, Fam Zheng wrote:
> > This moves the behavior of ne2000_can_receive to ne2000_receive. The
> > logic is when the NIC is stopped we drop the packet, when the buffer is
> > full we queue it and try flush later.
> >
> > ne2000_buffer_full is determined by s->curpag, s->boundary, s->start and
> > s->stop. Add a flush in ne2000_ioport_write as they are all updated
> > there, except the advancing of s->curpag in ne2000_receive where
> > ne2000_buffer_full is already false.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > hw/net/ne2000-isa.c | 1 -
> > hw/net/ne2000.c | 27 ++++++++++++++++-----------
> > 2 files changed, 16 insertions(+), 12 deletions(-)
>
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
>
Hi Stefan, I just notice there is still no pull req for this?
Fam
prev parent reply other threads:[~2015-08-19 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 1:08 [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive Fam Zheng
2015-07-03 10:41 ` Stefan Hajnoczi
2015-08-19 18:52 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150819185202.GA8816@dhcp-15-192.nay.redhat.com \
--to=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).