From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUAkU-00018F-LF for qemu-devel@nongnu.org; Tue, 25 Aug 2015 05:42:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUAkP-0001qB-Ef for qemu-devel@nongnu.org; Tue, 25 Aug 2015 05:42:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUAkP-0001nM-9b for qemu-devel@nongnu.org; Tue, 25 Aug 2015 05:42:29 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C364D8EA47 for ; Tue, 25 Aug 2015 09:42:27 +0000 (UTC) Date: Tue, 25 Aug 2015 12:42:23 +0300 From: "Michael S. Tsirkin" Message-ID: <20150825124140-mutt-send-email-mst@redhat.com> References: <1439939502-4722-1-git-send-email-ehabkost@redhat.com> <20150819095526.GB2332@work-vm> <20150819163020.GC32203@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150819163020.GC32203@thinpad.lan.raisama.net> Subject: Re: [Qemu-devel] [PATCH] q35: Remove old machine versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Marcel Apfelbaum , qemu-devel@nongnu.org, John Snow , Markus Armbruster , "Dr. David Alan Gilbert" , Paolo Bonzini , Laszlo Ersek On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: > On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: > > * Eduardo Habkost (ehabkost@redhat.com) wrote: > > > Migration with q35 was not possible before commit > > > 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > > > an ich9-ahci device, that was marked as unmigratable. So all q35 machines > > > before pc-q35-2.4 were unmigratable, and there's no point in keeping > > > compatibility code for them. > > > > > > Remove all old pc-q35 machine classes and keep only pc-q35-2.4. > > > > But doesn't that mean that anyone who has a machine configured with one > > of those machine types will suddenly find it wont start? > > Yes, and they will have to update their configuration to use pc-q35-2.4 > or newer. That seems easily avoidable: just make pc-q35-X alias pc-q35-2.4 for X < 2.4. > -- > Eduardo