From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34337)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUFex-0000Jv-4j
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 10:57:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUFes-0007JJ-5Q
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 10:57:11 -0400
Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:35911)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUFer-0007Hs-K9
	for qemu-devel@nongnu.org; Tue, 25 Aug 2015 10:57:05 -0400
Received: by wicja10 with SMTP id ja10so17785257wic.1
	for <qemu-devel@nongnu.org>; Tue, 25 Aug 2015 07:57:04 -0700 (PDT)
Date: Tue, 25 Aug 2015 15:57:02 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150825145702.GA8344@stefanha-thinkpad.redhat.com>
References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com>
	<1439563931-12352-7-git-send-email-guangrong.xiao@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1439563931-12352-7-git-send-email-guangrong.xiao@linux.intel.com>
Subject: Re: [Qemu-devel] [PATCH v2 06/18] pc: implement NVDIMM device
 abstract
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net

On Fri, Aug 14, 2015 at 10:51:59PM +0800, Xiao Guangrong wrote:
> +static void set_file(Object *obj, const char *str, Error **errp)
> +{
> +    PCNVDIMMDevice *nvdimm = PC_NVDIMM(obj);
> +
> +    if (nvdimm->file) {
> +        g_free(nvdimm->file);
> +    }

g_free(NULL) is a nop so it's safe to replace the if with just
g_free(nvdimm->file).