From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUFuC-0005cN-Qo for qemu-devel@nongnu.org; Tue, 25 Aug 2015 11:12:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUFu8-0001Tw-Py for qemu-devel@nongnu.org; Tue, 25 Aug 2015 11:12:56 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:35474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUFu8-0001Tm-K2 for qemu-devel@nongnu.org; Tue, 25 Aug 2015 11:12:52 -0400 Received: by wicne3 with SMTP id ne3so18338171wic.0 for ; Tue, 25 Aug 2015 08:12:51 -0700 (PDT) Date: Tue, 25 Aug 2015 16:12:47 +0100 From: Stefan Hajnoczi Message-ID: <20150825151247.GB8344@stefanha-thinkpad.redhat.com> References: <1439563931-12352-1-git-send-email-guangrong.xiao@linux.intel.com> <1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1439563931-12352-8-git-send-email-guangrong.xiao@linux.intel.com> Subject: Re: [Qemu-devel] [PATCH v2 07/18] nvdimm: reserve address range for NVDIMM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xiao Guangrong Cc: ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, gleb@kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: > diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c > index a53d235..7a270a8 100644 > --- a/hw/mem/nvdimm/pc-nvdimm.c > +++ b/hw/mem/nvdimm/pc-nvdimm.c > @@ -24,6 +24,19 @@ > > #include "hw/mem/pc-nvdimm.h" > > +#define PAGE_SIZE (1UL << 12) This macro name is likely to collide with system headers or other code. Could you use the existing TARGET_PAGE_SIZE constant instead?