From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52903) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMAJ-0002my-Vj for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:54:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUMAG-000094-Pq for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:53:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:54163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUMAG-00008p-M8 for qemu-devel@nongnu.org; Tue, 25 Aug 2015 17:53:56 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1168520B1B for ; Tue, 25 Aug 2015 17:53:56 -0400 (EDT) Date: Tue, 25 Aug 2015 17:54:19 -0400 From: "Emilio G. Cota" Message-ID: <20150825215419.GE29063@flamenco> References: <1440375847-17603-1-git-send-email-cota@braap.org> <1440375847-17603-32-git-send-email-cota@braap.org> <55DA6E38.7010404@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55DA6E38.7010404@redhat.com> Subject: Re: [Qemu-devel] [RFC 31/38] cpu: protect l1_map with tb_lock in full-system mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: mttcg@greensocs.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, guillaume.delbergue@greensocs.com, alex.bennee@linaro.org, Frederic Konrad On Sun, Aug 23, 2015 at 18:07:04 -0700, Paolo Bonzini wrote: > On 23/08/2015 17:24, Emilio G. Cota wrote: > > Note that user-only uses mmap_lock for this. > > > > Signed-off-by: Emilio G. Cota > > Why is this needed? The RCU-like page_find should work just fine. Ouch, you're right, forgot about that. Patch 30, which adds the tb_lock assertions, should change as well to only check for have_tb_lock in page_find when alloc==1. Thanks, Emilio