qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, qemu-block@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] Creating snapshots with specific runtime options
Date: Wed, 26 Aug 2015 13:57:13 +0100	[thread overview]
Message-ID: <20150826125713.GJ30715@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20150825135753.GA19764@perseus.local>

On Tue, Aug 25, 2015 at 04:57:53PM +0300, Alberto Garcia wrote:
> As far as I can see there's no way to create a snapshot and either
> 
>   a) inherit the runtime options from the original image
>   b) specify a new set of options
> 
> This comment in external_snapshot_prepare() before calling bdrv_open()
> suggests that the problem is known but the discussion was postponed.
> 
>     /* TODO Inherit bs->options or only take explicit options with an
>      * extended QMP command? */
> 
> I would like to retake this and make it possible. I discussed it
> briefly with Stefan on IRC and he said that Kevin might have some
> ideas.
> 
> In principle extending the QMP command sounds as simple as adding
> 'options': 'BlockdevOptions' to 'blockdev-snapshot-sync', but it's
> surely more complicated than that :) Is the 'BlockdevOptions' API even
> stable?

Some block drivers don't have BlockdevOptions support yet.

I think that doesn't prevent us from passing BlockdevOptions to snapshot
creation though.

  reply	other threads:[~2015-08-26 12:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 13:57 [Qemu-devel] Creating snapshots with specific runtime options Alberto Garcia
2015-08-26 12:57 ` Stefan Hajnoczi [this message]
2015-08-28  8:28   ` Alberto Garcia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150826125713.GJ30715@stefanha-thinkpad.redhat.com \
    --to=stefanha@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).