From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()
Date: Wed, 26 Aug 2015 16:51:40 +0200 [thread overview]
Message-ID: <20150826165140.6bab7d28@bahia.local> (raw)
In-Reply-To: <CAFEAcA_ccNp2tM9HcL7L3ungaWaQ-uk6vq9swaUjEB77WfyZhQ@mail.gmail.com>
On Wed, 26 Aug 2015 15:21:59 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 26 August 2015 at 11:04, Jason Wang <jasowang@redhat.com> wrote:
> > Wildcard mmio eventfd use zero size, but it will lead abort() since it
> > was illegal in adjust_endianness(). Fix this by allowing zero size.
> >
> > Cc: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> This seems to me like a bug in the caller. Why would anything
> try to call into the memory subsystem to do a zero-size
> transaction?
>
> thanks
> -- PMM
>
Here's the patch which needs zero-size eventfd:
http://patchwork.ozlabs.org/patch/509428/
Cheers.
--
Greg
next prev parent reply other threads:[~2015-08-26 15:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 10:04 [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness() Jason Wang
2015-08-26 10:04 ` [Qemu-devel] [PATCH 2/2] pci: test-dev: try to test fast mmio bus for wildcard mmio event Jason Wang
2015-08-27 10:28 ` Michael S. Tsirkin
2015-08-26 14:21 ` [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness() Peter Maydell
2015-08-26 14:51 ` Greg Kurz [this message]
2015-08-27 4:50 ` Jason Wang
2015-08-27 10:49 ` Peter Maydell
2015-08-27 10:53 ` Michael S. Tsirkin
2015-08-27 11:04 ` Peter Maydell
2015-08-27 11:08 ` Michael S. Tsirkin
2015-08-27 12:12 ` Peter Maydell
2015-08-27 12:17 ` Michael S. Tsirkin
2015-08-27 12:20 ` Peter Maydell
2015-08-27 12:25 ` Michael S. Tsirkin
2015-08-27 12:27 ` Peter Maydell
2015-08-27 12:30 ` Michael S. Tsirkin
2015-08-27 13:10 ` Greg Kurz
2015-08-28 2:23 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826165140.6bab7d28@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).