From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUcrp-0003Tm-Qk for qemu-devel@nongnu.org; Wed, 26 Aug 2015 11:44:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUcrk-0004yy-Mh for qemu-devel@nongnu.org; Wed, 26 Aug 2015 11:44:01 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:53602) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUcrk-0004yj-7g for qemu-devel@nongnu.org; Wed, 26 Aug 2015 11:43:56 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 26 Aug 2015 16:43:53 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1412C17D80DC for ; Wed, 26 Aug 2015 15:59:45 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7QEw3qd21495990 for ; Wed, 26 Aug 2015 14:58:06 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7QEvrha026955 for ; Wed, 26 Aug 2015 08:57:53 -0600 Date: Wed, 26 Aug 2015 16:57:42 +0200 From: Cornelia Huck Message-ID: <20150826165742.4bb3c4eb.cornelia.huck@de.ibm.com> In-Reply-To: <1440595482-15503-1-git-send-email-pmorel@linux.vnet.ibm.com> References: <1440595482-15503-1-git-send-email-pmorel@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] virtio dataplane: adapt dataplane for virtio Version 1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pierre Morel Cc: mst@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, gkurz@linux.vnet.ibm.com On Wed, 26 Aug 2015 15:24:42 +0200 Pierre Morel wrote: > Let dataplane allocate different region for the desc/avail/used s/region/regions/ > ring regions. > > Signed-off-by: Pierre Morel > Acked-by: Greg Kurz > Tested-by: Greg Kurz > --- > hw/virtio/dataplane/vring.c | 48 ++++++++++++++++++++++++++----------- > include/hw/virtio/dataplane/vring.h | 4 +++- > 2 files changed, 37 insertions(+), 15 deletions(-) > > diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c > index 07fd69c..ad86be5 100644 > --- a/hw/virtio/dataplane/vring.c > +++ b/hw/virtio/dataplane/vring.c > @@ -65,24 +65,34 @@ static void vring_unmap(void *buffer, bool is_write) > } > > /* Map the guest's vring to host memory */ > + > +#define MAP_VRING_DESCRIPTOR(d) { \ > + hwaddr addr; \ > + hwaddr size; \ > + void *ptr; \ > + \ > + addr = virtio_queue_get_##d##_addr(vdev, n); \ > + size = virtio_queue_get_##d## _size(vdev, n); \ Inconsistent spacing (but probably can be fixed when applying). > + ptr = vring_map(&vring->mr_##d, addr, size, true); \ > + if (!ptr) { \ > + error_report("Failed to map vring "#d" " \ > + "addr %#" HWADDR_PRIx " size %" HWADDR_PRIu, \ > + addr, size); \ > + goto out_err_##d; \ > + } \ > + vr->d = ptr; \ > + } > + > bool vring_setup(Vring *vring, VirtIODevice *vdev, int n) > { > - hwaddr vring_addr = virtio_queue_get_ring_addr(vdev, n); > - hwaddr vring_size = virtio_queue_get_ring_size(vdev, n); > - void *vring_ptr; > + struct vring *vr = &vring->vr; > > vring->broken = false; > + vr->num = virtio_queue_get_num(vdev, n); > > - vring_ptr = vring_map(&vring->mr, vring_addr, vring_size, true); > - if (!vring_ptr) { > - error_report("Failed to map vring " > - "addr %#" HWADDR_PRIx " size %" HWADDR_PRIu, > - vring_addr, vring_size); > - vring->broken = true; > - return false; > - } > - > - vring_init(&vring->vr, virtio_queue_get_num(vdev, n), vring_ptr, 4096); > + MAP_VRING_DESCRIPTOR(desc); > + MAP_VRING_DESCRIPTOR(avail); > + MAP_VRING_DESCRIPTOR(used); > > vring->last_avail_idx = virtio_queue_get_last_avail_idx(vdev, n); > vring->last_used_idx = vring_get_used_idx(vdev, vring); > @@ -92,6 +102,14 @@ bool vring_setup(Vring *vring, VirtIODevice *vdev, int n) > trace_vring_setup(virtio_queue_get_ring_addr(vdev, n), > vring->vr.desc, vring->vr.avail, vring->vr.used); > return true; > + > +out_err_used: > + memory_region_unref(vring->mr_avail); > +out_err_avail: > + memory_region_unref(vring->mr_desc); > +out_err_desc: > + vring->broken = true; > + return false; My only worry is that this might be a bit hard to parse as the gotos are hidden in the macro. But in the end, both this and the original version are basically fine. > } > > void vring_teardown(Vring *vring, VirtIODevice *vdev, int n) Reviewed-by: Cornelia Huck