From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
yhindin@redhat.com, Leonid Bloch <leonid@daynix.com>,
QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed
Date: Thu, 27 Aug 2015 08:42:02 -0500 [thread overview]
Message-ID: <20150827134202.25622.79364@loki> (raw)
In-Reply-To: <CAJ+F1CLKrLYOS6fTh_sRBfqO+2sy2QA5MbqdqWwW90jXYXqb+g@mail.gmail.com>
Quoting Marc-André Lureau (2015-08-27 07:41:17)
> Hi
>
> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> <mdroth@linux.vnet.ibm.com> wrote:
> > This makes it easier to report on whether or not MSI support was
> > enabled via probe by looking at the ./configure summary.
>
> Sorry I don't get what that really changes. Otherwise the patch looks fine.
If we keep the $enabled != "no" logic all the way through, $enabled,
unless explicitly turned off or missing dependencies, will be
undefined when the configure options are summarized via:
configure: qemu-ga: report MSI install support in summary
requiring the user to infer whether we'll default to "yes" or "no".
The current logic in fact defaults to "yes" in function, so with this
patch we're simply setting that flag early on so we can report "yes"
rather than undefined.
>
>
> --
> Marc-André Lureau
>
next prev parent reply other threads:[~2015-08-27 13:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 22:21 [Qemu-devel] [0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-26 22:21 ` [Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe Michael Roth
2015-08-27 12:31 ` Marc-André Lureau
2015-08-26 22:21 ` [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed Michael Roth
2015-08-27 12:41 ` Marc-André Lureau
2015-08-27 13:42 ` Michael Roth [this message]
2015-08-27 14:05 ` Marc-André Lureau
2015-08-27 19:10 ` Michael Roth
2015-08-26 22:21 ` [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies Michael Roth
2015-08-27 12:49 ` Marc-André Lureau
2015-08-27 13:46 ` Michael Roth
2015-08-27 14:00 ` Marc-André Lureau
2015-08-26 22:21 ` [Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message Michael Roth
2015-08-27 12:50 ` Marc-André Lureau
-- strict thread matches above, loose matches on Subject: below --
2015-08-27 23:55 [Qemu-devel] [PATCH v2 0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support Michael Roth
2015-08-27 23:55 ` [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150827134202.25622.79364@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=leonid@daynix.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhindin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).