From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47752) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUxRe-0003La-MU for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:42:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUxRZ-0000Ka-Jt for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:42:22 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:45757) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUxRZ-0000Ec-Ba for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:42:17 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 27 Aug 2015 07:42:15 -0600 Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 0F42CC90042 for ; Thu, 27 Aug 2015 09:33:16 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7RDgBmI53805236 for ; Thu, 27 Aug 2015 13:42:11 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7RDgAC6025250 for ; Thu, 27 Aug 2015 09:42:11 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <1440627694-25096-1-git-send-email-mdroth@linux.vnet.ibm.com> <1440627694-25096-3-git-send-email-mdroth@linux.vnet.ibm.com> Message-ID: <20150827134202.25622.79364@loki> Date: Thu, 27 Aug 2015 08:42:02 -0500 Subject: Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Cc: Paolo Bonzini , yhindin@redhat.com, Leonid Bloch , QEMU Quoting Marc-Andr=C3=A9 Lureau (2015-08-27 07:41:17) > Hi > = > On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth > wrote: > > This makes it easier to report on whether or not MSI support was > > enabled via probe by looking at the ./configure summary. > = > Sorry I don't get what that really changes. Otherwise the patch looks fin= e. If we keep the $enabled !=3D "no" logic all the way through, $enabled, unless explicitly turned off or missing dependencies, will be undefined when the configure options are summarized via: configure: qemu-ga: report MSI install support in summary requiring the user to infer whether we'll default to "yes" or "no". The current logic in fact defaults to "yes" in function, so with this patch we're simply setting that flag early on so we can report "yes" rather than undefined. > = > = > -- = > Marc-Andr=C3=A9 Lureau >=20