From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49402)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZUxW8-0004qv-BI
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:47:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZUxW4-00032h-8R
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:47:00 -0400
Received: from e17.ny.us.ibm.com ([129.33.205.207]:43825)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1ZUxW4-00032F-3i
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:46:56 -0400
Received: from /spool/local
	by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Thu, 27 Aug 2015 09:46:55 -0400
Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com
	[9.57.198.27])
	by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 925BCC90041
	for <qemu-devel@nongnu.org>; Thu, 27 Aug 2015 09:37:58 -0400 (EDT)
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	t7RDkrn451511518
	for <qemu-devel@nongnu.org>; Thu, 27 Aug 2015 13:46:53 GMT
Received: from d01av02.pok.ibm.com (localhost [127.0.0.1])
	by d01av02.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	t7RDkrri029077
	for <qemu-devel@nongnu.org>; Thu, 27 Aug 2015 09:46:53 -0400
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <CAJ+F1CLfqFm+OYw-UfAe9-wJVJcvDbX=gjVBORuX09YDj2vXfA@mail.gmail.com>
References: <1440627694-25096-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1440627694-25096-4-git-send-email-mdroth@linux.vnet.ibm.com>
	<CAJ+F1CLfqFm+OYw-UfAe9-wJVJcvDbX=gjVBORuX09YDj2vXfA@mail.gmail.com>
Message-ID: <20150827134643.25622.35602@loki>
Date: Thu, 27 Aug 2015 08:46:43 -0500
Subject: Re: [Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, yhindin@redhat.com, Leonid Bloch <leonid@daynix.com>, QEMU <qemu-devel@nongnu.org>

Quoting Marc-Andr=C3=A9 Lureau (2015-08-27 07:49:19)
> Hi
> =

> On Thu, Aug 27, 2015 at 12:21 AM, Michael Roth
> <mdroth@linux.vnet.ibm.com> wrote:
> > +qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_P=
ROVIDER)
> > +       $(call LINK, $(filter-out %.tlb %.dll, $^))
> =

> Strictly this is not so great, but that makes sense: so perhaps a
> small comment above to explain it would be good.

Will add a comment either way, but perhaps something like:

qemu-ga$(EXESUF): $(qga-obj-y) libqemuutil.a libqemustub.a $(QGA_VSS_PROVID=
ER)
       $(call LINK, $(filter-out $(QGA_VSS_PROVIDER), $^))

would be clearer? I suppose it's a bit more future-proof as well, if we add=
ed
more dependencies to QGA_VSS_PROVIDER for some reason.

> =

> Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
> =

> =

> =

> -- =

> Marc-Andr=C3=A9 Lureau
>=20