From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUulp-0002p5-3W for qemu-devel@nongnu.org; Thu, 27 Aug 2015 06:51:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZUulk-0000wc-On for qemu-devel@nongnu.org; Thu, 27 Aug 2015 06:51:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZUulk-0000wU-K3 for qemu-devel@nongnu.org; Thu, 27 Aug 2015 06:50:56 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4D7D9C1C49F7 for ; Thu, 27 Aug 2015 10:50:56 +0000 (UTC) Date: Thu, 27 Aug 2015 13:50:52 +0300 From: "Michael S. Tsirkin" Message-ID: <20150827135022-mutt-send-email-mst@redhat.com> References: <1439939502-4722-1-git-send-email-ehabkost@redhat.com> <20150819095526.GB2332@work-vm> <20150819163020.GC32203@thinpad.lan.raisama.net> <20150825124140-mutt-send-email-mst@redhat.com> <55DC94C4.6000205@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55DC94C4.6000205@redhat.com> Subject: Re: [Qemu-devel] [PATCH] q35: Remove old machine versions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: Eduardo Habkost , Marcel Apfelbaum , qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Laszlo Ersek , "Dr. David Alan Gilbert" On Tue, Aug 25, 2015 at 12:16:04PM -0400, John Snow wrote: > > > On 08/25/2015 05:42 AM, Michael S. Tsirkin wrote: > > On Wed, Aug 19, 2015 at 09:30:20AM -0700, Eduardo Habkost wrote: > >> On Wed, Aug 19, 2015 at 10:55:26AM +0100, Dr. David Alan Gilbert wrote: > >>> * Eduardo Habkost (ehabkost@redhat.com) wrote: > >>>> Migration with q35 was not possible before commit > >>>> 04329029a8c539eb5f75dcb6d8b016f0c53a031a, because q35 unconditionally creates > >>>> an ich9-ahci device, that was marked as unmigratable. So all q35 machines > >>>> before pc-q35-2.4 were unmigratable, and there's no point in keeping > >>>> compatibility code for them. > >>>> > >>>> Remove all old pc-q35 machine classes and keep only pc-q35-2.4. > >>> > >>> But doesn't that mean that anyone who has a machine configured with one > >>> of those machine types will suddenly find it wont start? > >> > >> Yes, and they will have to update their configuration to use pc-q35-2.4 > >> or newer. > > > > That seems easily avoidable: just make pc-q35-X alias pc-q35-2.4 for X < 2.4. > > > > Both Marcel and Markus would prefer it to fail outright instead of > silently perform magic, in response to my suggesting the same thing. I think it's result of a misunderstanding - let's discuss some more. > >> -- > >> Eduardo