From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUxZj-0007Rr-TU
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:50:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUxZf-0007zb-PG
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:50:43 -0400
Date: Thu, 27 Aug 2015 14:50:35 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150827135035.GA4917@stefanha-thinkpad.redhat.com>
References: <1438144934-23619-1-git-send-email-famz@redhat.com>
	<1438144934-23619-2-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438144934-23619-2-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/11] aio: Introduce
 "type" in aio_set_fd_handler and aio_set_event_notifier
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Jul 29, 2015 at 12:42:04PM +0800, Fam Zheng wrote:
> The parameter is added but not used.
> 
> The callers are converted with following coccinelle semantic patch:
> 
>     @@
>     expression E1, E2, E3, E4, E5;
>     @@
>     (
>     -aio_set_event_notifier(E1, E2, E3)
>     +aio_set_event_notifier(E1, E2, AIO_CLIENT_UNSPECIFIED, E3)
>     |
>     -aio_set_fd_handler(E1, E2, E3, E4, E5)
>     +aio_set_fd_handler(E1, E2, AIO_CLIENT_UNSPECIFIED, E3, E4, E5)
>     )
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  aio-posix.c                     |  4 ++-
>  aio-win32.c                     |  2 ++
>  async.c                         |  3 ++-
>  block/curl.c                    | 14 +++++-----
>  block/iscsi.c                   |  9 +++----
>  block/linux-aio.c               |  5 ++--
>  block/nbd-client.c              | 10 ++++---
>  block/nfs.c                     | 17 +++++-------
>  block/sheepdog.c                | 32 +++++++++++++++--------
>  block/ssh.c                     |  5 ++--
>  block/win32-aio.c               |  5 ++--
>  hw/block/dataplane/virtio-blk.c |  6 +++--
>  hw/scsi/virtio-scsi-dataplane.c | 24 +++++++++++------
>  include/block/aio.h             |  5 ++++
>  nbd.c                           |  4 ++-
>  tests/test-aio.c                | 58 +++++++++++++++++++++++------------------
>  16 files changed, 122 insertions(+), 81 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>