From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUxct-0002S7-Mx
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:54:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZUxcp-0001zU-KT
	for qemu-devel@nongnu.org; Thu, 27 Aug 2015 09:53:59 -0400
Date: Thu, 27 Aug 2015 14:53:52 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150827135352.GC4917@stefanha-thinkpad.redhat.com>
References: <1438144934-23619-1-git-send-email-famz@redhat.com>
	<1438144934-23619-4-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438144934-23619-4-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd
 handlers as "protocol"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote:
> diff --git a/include/block/aio.h b/include/block/aio.h
> index bd1d44b..d02ddfa 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx);
>  bool aio_dispatch(AioContext *ctx);
>  
>  #define AIO_CLIENT_UNSPECIFIED    (1 << 0)
> +#define AIO_CLIENT_PROTOCOL       (1 << 1)

The semantics need to be documented here, not just in the commit
description.

AIO_CLIENT_BLOCK_DRIVER or AIO_CLIENT_BLOCK_PROTOCOL seems like a
clearer name to me since "protocol" just by itself could mean many
things.