From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVFSU-0006w7-RI for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:56:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZVFSP-0002yM-O5 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:56:26 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:33179) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZVFSP-0002xo-F2 for qemu-devel@nongnu.org; Fri, 28 Aug 2015 04:56:21 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Aug 2015 09:56:19 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id DC78E2190073 for ; Fri, 28 Aug 2015 09:55:48 +0100 (BST) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t7S8uC3227001052 for ; Fri, 28 Aug 2015 08:56:15 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t7S8u3bZ011428 for ; Fri, 28 Aug 2015 02:56:03 -0600 Date: Fri, 28 Aug 2015 10:55:52 +0200 From: Cornelia Huck Message-ID: <20150828105552.6d0cb4ac.cornelia.huck@de.ibm.com> In-Reply-To: <55E01CD5.40002@vivier.eu> References: <1440445026-26522-1-git-send-email-rth@twiddle.net> <1440445026-26522-19-git-send-email-rth@twiddle.net> <20150828102150.4b1c3e6d.cornelia.huck@de.ibm.com> <55E01CD5.40002@vivier.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 18/18] linux-user: remove useless macros GUEST_BASE and RESERVED_VA List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Richard Henderson On Fri, 28 Aug 2015 10:33:25 +0200 Laurent Vivier wrote: >=20 >=20 > Le 28/08/2015 10:21, Cornelia Huck a =C3=A9crit : > > On Mon, 24 Aug 2015 12:37:06 -0700 > > Richard Henderson wrote: > >=20 > >> From: Laurent Vivier > >> > >> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base > >> and the macros GUEST_BASE and RESERVED_VA become useless: replace > >> them by their values. > >> > >> Reviewed-by: Alexander Graf > >> Signed-off-by: Laurent Vivier > >> Message-Id: <1440420834-8388-1-git-send-email-laurent@vivier.eu> > >> Signed-off-by: Richard Henderson > >> --- > >> include/exec/cpu-all.h | 4 +--- > >> include/exec/cpu_ldst.h | 8 ++++---- > >> linux-user/mmap.c | 20 ++++++++++---------- > >> tcg/aarch64/tcg-target.c | 10 +++++----- > >> tcg/arm/tcg-target.c | 8 ++++---- > >> tcg/i386/tcg-target.c | 22 +++++++++++----------- > >> tcg/ia64/tcg-target.c | 21 +++++++++------------ > >> tcg/mips/tcg-target.c | 16 ++++++++-------- > >> tcg/ppc/tcg-target.c | 12 ++++-------- > >> tcg/s390/tcg-target.c | 13 ++++--------- > >> tcg/sparc/tcg-target.c | 8 ++++---- > >> 11 files changed, 64 insertions(+), 78 deletions(-) > >=20 > > This seems to break compilation on s390 for me: > >=20 > > In file included from /home/cohuck/git/qemu/tcg/tcg.c:258:0: > > /home/cohuck/git/qemu/tcg/s390/tcg-target.c: In function =E2=80=98tcg_t= arget_qemu_prologue=E2=80=99: > > /home/cohuck/git/qemu/tcg/s390/tcg-target.c:2347:9: error: =E2=80=98gue= st_base=E2=80=99 undeclared (first use in this function) > > if (guest_base >=3D 0x80000) { > > ^ > > (once for each of the softmmu subdirs I build) > >=20 > > config.log says: > >=20 > > # Configured with: '/home/cohuck/git/qemu/build/../configure' '--target= -list=3Ds390x-softmmu s390x-linux-user aarch64-softmmu arm-softmmu mips-sof= tmmu ppc-softmmu ppc64-softmmu' '--enable-kvm' '--enable-vhost-net' '--enab= le-virtio-blk-data-plane' '--enable-linux-aio' >=20 > I've tested the compilation for all targets but only on x86_64... :( >=20 > The use of guest_base must be surrounded by "#ifndef CONFIG_SOFTMMU", it > is not the case for s390 (see other host tcg). >=20 > Can you fix this or do you want I write a patch ? I'd prefer if you could do that.