From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40708)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZVIBJ-0000CP-Lj
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 07:50:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1ZVIBG-0008MR-Dq
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 07:50:53 -0400
Date: Fri, 28 Aug 2015 12:50:46 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20150828115046.GI4917@stefanha-thinkpad.redhat.com>
References: <1438144934-23619-1-git-send-email-famz@redhat.com>
	<1438144934-23619-10-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1438144934-23619-10-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 09/11] block: Introduce
	bdrv_aio_poll
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Jul 29, 2015 at 12:42:12PM +0800, Fam Zheng wrote:
> +bool bdrv_aio_poll(AioContext *ctx, bool blocking)
> +{
> +    bool ret;
> +
> +    ret = aio_poll(ctx, blocking);
> +    return ret;
> +}

This function would fit into bdrv_*() APIs better if the first argument
was BlockDriverState *bs instead of an AioContext.