From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42179)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZVNg3-0007Cz-0x
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 13:42:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1ZVNg1-0004Qw-U1
	for qemu-devel@nongnu.org; Fri, 28 Aug 2015 13:42:58 -0400
Date: Fri, 28 Aug 2015 13:42:43 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20150828174243.GE31272@localhost.localdomain>
References: <1440671441-7978-1-git-send-email-pl@kamp.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1440671441-7978-1-git-send-email-pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCH V3] block/nfs: cache allocated filesize for
 read-only files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org

On Thu, Aug 27, 2015 at 12:30:41PM +0200, Peter Lieven wrote:
> If the file is readonly its not expected to grow so
> save the blocking call to nfs_fstat_async and use
> the value saved at connection time. Also important
> the monitor (and thus the main loop) will not hang
> if block device info is queried and the NFS share
> is unresponsive.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> v1->v2: update cache on reopen_prepare [Max]
> v2->v3: use cache only if cache.direct=off [Max]
> 

Reviewed-by: Jeff Cody <jcody@redhat.com>