From: David Gibson <david@gibson.dropbear.id.au>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Marcel Apfelbaum" <marcel.a@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 02/10] vexpress: Don't set name on abstract class
Date: Sun, 30 Aug 2015 16:42:37 +1000 [thread overview]
Message-ID: <20150830064237.GA11475@voom.redhat.com> (raw)
In-Reply-To: <1440107676-17326-3-git-send-email-ehabkost@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On Thu, Aug 20, 2015 at 02:54:28PM -0700, Eduardo Habkost wrote:
> The MachineClass::name field won't be ever be used on TYPE_VEXPRESS, as
> it is an abstract class and the machine class lookup code explicitly
> skips abstract classes. We can remove it to make the code simpler.
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-08-30 6:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 21:54 [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix Eduardo Habkost
2015-08-20 21:54 ` [Qemu-devel] [PATCH 01/10] machine: MACHINE_TYPE_NAME macro Eduardo Habkost
2015-08-25 8:53 ` Marcel Apfelbaum
2015-08-30 5:59 ` David Gibson
2015-08-20 21:54 ` [Qemu-devel] [PATCH 02/10] vexpress: Don't set name on abstract class Eduardo Habkost
2015-08-30 6:42 ` David Gibson [this message]
2015-08-20 21:54 ` [Qemu-devel] [PATCH 03/10] vexpress: Rename machine classes to use MACHINE_TYPE_NAME Eduardo Habkost
2015-08-30 6:43 ` David Gibson
2015-09-19 6:30 ` Andreas Färber
2015-09-19 6:37 ` Andreas Färber
2015-08-20 21:54 ` [Qemu-devel] [PATCH 04/10] arm: Rename virt machine class " Eduardo Habkost
2015-08-30 6:43 ` David Gibson
2015-08-20 21:54 ` [Qemu-devel] [PATCH 05/10] pseries: Rename machine class names " Eduardo Habkost
2015-08-30 6:45 ` David Gibson
2015-08-20 21:54 ` [Qemu-devel] [PATCH 06/10] s390-virtio: Rename machine class name " Eduardo Habkost
2015-08-30 6:46 ` David Gibson
2015-08-20 21:54 ` [Qemu-devel] [PATCH 07/10] s390: Rename s390-ccw-virtio-2.4 " Eduardo Habkost
2015-08-30 6:46 ` David Gibson
2015-09-04 8:52 ` Christian Borntraeger
2015-09-04 14:54 ` Eduardo Habkost
2015-09-04 14:56 ` Andreas Färber
2015-09-04 15:06 ` Eduardo Habkost
2015-09-04 15:42 ` Eduardo Habkost
2015-08-20 21:54 ` [Qemu-devel] [PATCH 08/10] mac99: Use MACHINE_TYPE_NAME to encode class name Eduardo Habkost
2015-08-30 6:46 ` David Gibson
2015-08-20 21:54 ` [Qemu-devel] [PATCH 09/10] machine: Ensure all TYPE_MACHINE subclasses have the right suffix Eduardo Habkost
2015-08-25 8:53 ` Marcel Apfelbaum
2015-08-20 21:54 ` [Qemu-devel] [PATCH 10/10] machine: Set MachineClass::name automatically Eduardo Habkost
2015-08-25 8:50 ` Marcel Apfelbaum
2015-08-26 15:02 ` Eduardo Habkost
2015-08-26 16:13 ` Marcel Apfelbaum
2015-09-04 15:46 ` Eduardo Habkost
2015-09-19 6:23 ` Andreas Färber
2015-09-19 6:39 ` Andreas Färber
2015-08-21 10:23 ` [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix Cornelia Huck
2015-08-21 15:44 ` Eduardo Habkost
2015-09-02 19:58 ` Eduardo Habkost
2015-09-03 7:39 ` Cornelia Huck
2015-09-06 19:25 ` Andreas Färber
2015-09-07 9:05 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150830064237.GA11475@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=marcel.a@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).