[Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

[Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

[Soren Brinkmann]

The macro is defined twice in identical ways.

Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
I have the feeling I'm missing a tiny one-letter difference or some
ifdef, but I believe the mentioned macro is defined twice.

	Sören
---
 include/migration/vmstate.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 2e5a97dec4ed..9a65522da190 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -754,9 +754,6 @@ extern const VMStateInfo vmstate_info_bitmap;
 #define VMSTATE_UINT32_SUB_ARRAY(_f, _s, _start, _num)                \
     VMSTATE_SUB_ARRAY(_f, _s, _start, _num, 0, vmstate_info_uint32, uint32_t)
 
-#define VMSTATE_UINT32_ARRAY(_f, _s, _n)                              \
-    VMSTATE_UINT32_ARRAY_V(_f, _s, _n, 0)
-
 #define VMSTATE_INT64_ARRAY_V(_f, _s, _n, _v)                         \
     VMSTATE_ARRAY(_f, _s, _n, _v, vmstate_info_int64, int64_t)
 
-- 
2.5.0.3.g52d66ab

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

[Peter Maydell]

On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> The macro is defined twice in identical ways.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> I have the feeling I'm missing a tiny one-letter difference or some
> ifdef, but I believe the mentioned macro is defined twice.

Duplicate accidentally introduced way back in
commit 9ba2f6601d92c73 as far as I can tell.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

[Sören Brinkmann]

On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote:
> On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> > The macro is defined twice in identical ways.
> >
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > ---
> > I have the feeling I'm missing a tiny one-letter difference or some
> > ifdef, but I believe the mentioned macro is defined twice.
> 
> Duplicate accidentally introduced way back in
> commit 9ba2f6601d92c73 as far as I can tell.
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Thanks for reviewing.
Does anybody pick that up?

	Thanks,
	Sören

Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY

[Amit Shah]

On (Wed) 26 Aug 2015 [14:26:55], Sören Brinkmann wrote:
> On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote:
> > On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> > > The macro is defined twice in identical ways.
> > >
> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > > ---
> > > I have the feeling I'm missing a tiny one-letter difference or some
> > > ifdef, but I believe the mentioned macro is defined twice.
> > 
> > Duplicate accidentally introduced way back in
> > commit 9ba2f6601d92c73 as far as I can tell.
> > 
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 
> Thanks for reviewing.
> Does anybody pick that up?

Yes, we will.

Thanks,

		Amit