* [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY
@ 2015-08-14 6:16 Soren Brinkmann
2015-08-14 8:48 ` Peter Maydell
0 siblings, 1 reply; 4+ messages in thread
From: Soren Brinkmann @ 2015-08-14 6:16 UTC (permalink / raw)
To: Juan Quintela, Amit Shah; +Cc: qemu-devel, Soren Brinkmann
The macro is defined twice in identical ways.
Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
---
I have the feeling I'm missing a tiny one-letter difference or some
ifdef, but I believe the mentioned macro is defined twice.
Sören
---
include/migration/vmstate.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 2e5a97dec4ed..9a65522da190 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -754,9 +754,6 @@ extern const VMStateInfo vmstate_info_bitmap;
#define VMSTATE_UINT32_SUB_ARRAY(_f, _s, _start, _num) \
VMSTATE_SUB_ARRAY(_f, _s, _start, _num, 0, vmstate_info_uint32, uint32_t)
-#define VMSTATE_UINT32_ARRAY(_f, _s, _n) \
- VMSTATE_UINT32_ARRAY_V(_f, _s, _n, 0)
-
#define VMSTATE_INT64_ARRAY_V(_f, _s, _n, _v) \
VMSTATE_ARRAY(_f, _s, _n, _v, vmstate_info_int64, int64_t)
--
2.5.0.3.g52d66ab
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY
2015-08-14 6:16 [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY Soren Brinkmann
@ 2015-08-14 8:48 ` Peter Maydell
2015-08-26 21:26 ` Sören Brinkmann
0 siblings, 1 reply; 4+ messages in thread
From: Peter Maydell @ 2015-08-14 8:48 UTC (permalink / raw)
To: Soren Brinkmann; +Cc: Amit Shah, QEMU Developers, Juan Quintela
On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> The macro is defined twice in identical ways.
>
> Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> ---
> I have the feeling I'm missing a tiny one-letter difference or some
> ifdef, but I believe the mentioned macro is defined twice.
Duplicate accidentally introduced way back in
commit 9ba2f6601d92c73 as far as I can tell.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY
2015-08-14 8:48 ` Peter Maydell
@ 2015-08-26 21:26 ` Sören Brinkmann
2015-08-31 4:59 ` Amit Shah
0 siblings, 1 reply; 4+ messages in thread
From: Sören Brinkmann @ 2015-08-26 21:26 UTC (permalink / raw)
To: Peter Maydell
Cc: Amit Shah, QEMU Developers, Sören Brinkmann, Juan Quintela
On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote:
> On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> > The macro is defined twice in identical ways.
> >
> > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > ---
> > I have the feeling I'm missing a tiny one-letter difference or some
> > ifdef, but I believe the mentioned macro is defined twice.
>
> Duplicate accidentally introduced way back in
> commit 9ba2f6601d92c73 as far as I can tell.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Thanks for reviewing.
Does anybody pick that up?
Thanks,
Sören
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY
2015-08-26 21:26 ` Sören Brinkmann
@ 2015-08-31 4:59 ` Amit Shah
0 siblings, 0 replies; 4+ messages in thread
From: Amit Shah @ 2015-08-31 4:59 UTC (permalink / raw)
To: Sören Brinkmann; +Cc: Peter Maydell, QEMU Developers, Juan Quintela
On (Wed) 26 Aug 2015 [14:26:55], Sören Brinkmann wrote:
> On Fri, 2015-08-14 at 09:48AM +0100, Peter Maydell wrote:
> > On 14 August 2015 at 07:16, Soren Brinkmann <soren.brinkmann@xilinx.com> wrote:
> > > The macro is defined twice in identical ways.
> > >
> > > Signed-off-by: Soren Brinkmann <soren.brinkmann@xilinx.com>
> > > ---
> > > I have the feeling I'm missing a tiny one-letter difference or some
> > > ifdef, but I believe the mentioned macro is defined twice.
> >
> > Duplicate accidentally introduced way back in
> > commit 9ba2f6601d92c73 as far as I can tell.
> >
> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>
> Thanks for reviewing.
> Does anybody pick that up?
Yes, we will.
Thanks,
Amit
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-31 4:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 6:16 [Qemu-devel] [PATCH QEMU] vmstate: Remove redefinition of VMSTATE_UINT32_ARRAY Soren Brinkmann
2015-08-14 8:48 ` Peter Maydell
2015-08-26 21:26 ` Sören Brinkmann
2015-08-31 4:59 ` Amit Shah
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).