From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWZjn-00012L-78 for qemu-devel@nongnu.org; Mon, 31 Aug 2015 20:47:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWZjj-00059K-Sx for qemu-devel@nongnu.org; Mon, 31 Aug 2015 20:47:47 -0400 Date: Tue, 1 Sep 2015 09:55:05 +1000 From: David Gibson Message-ID: <20150831235505.GH11475@voom.redhat.com> References: <1440999493-5190-1-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gTtJ75FAzB1T2CN6" Content-Disposition: inline In-Reply-To: <1440999493-5190-1-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [FIX v1 PATCH] spapr_rtas: Prevent QEMU crash during hotplug without a prior device_add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Michael Roth --gTtJ75FAzB1T2CN6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 31, 2015 at 11:08:13AM +0530, Bharata B Rao wrote: > If drmgr is used in the guest to hotplug a device before a device_add > has been issued via the QEMU monitor, QEMU segfaults in configure_connect= or > call. This occurs due to accessing of NULL FDT which otherwise would have > been created and associated with the DRC during device_add command. >=20 > Check for NULL FDT and return failure from configure_connector call. > As per PAPR+, an error value of -9003 seems appropriate for this failure. >=20 > Signed-off-by: Bharata B Rao > Cc: Michael Roth Applied to spapr-next, thanks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gTtJ75FAzB1T2CN6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV5OlZAAoJEGw4ysog2bOS1cAP/2JztOV7DYJzt5+/HmwudXiM no11nHC+WMR1bzv2JB7ycOIVTeKHssBbk2lyVdeHrOkMr7iQ7WV5vmrt0Pc+dEpV Qo1CtW3SO9AaXjBQa32IPnTYQNLs0lJa5FsrEeGX0AHaobO9WpujHdbFX91T4Hhv AHaeSRNxn39FReyEluFSBDbP3pwHOO0PjDcnoijQXsZgWo+TK6ZmT/eokNJcwx5r UNrh5lk8Dp0iMgYLMPhznkg/qLqMORjy1iQSjyAGkP2cWfA4SZ5ghgA2/iPQPEDZ 2bbK6ND7fMpUAMrxzV8IECZEdqq5oc3dN6EdlAuPfiU7Hv8rLmM2PWBx6GwugT7q U1xAcl7gAcajTv8QDNsx4aTqzy0/e3m6OS4s+8tdHzyR5eBnJQO9YT5SmkqEjwvA 0WO8unE5xtj29PFyxXr0mqx7PX6fUeumrmYDSqGPWvkmyLaOHRSzfqkTJuCVPFyK l6IMNbmTDwZoHOoJNgmdz2gGOZag5Xvrls04dJ1COLzDzcprzTG2ltOc9eARMdK/ ZTcm2BHewJFesE2Go9B/rVxX+/az5g3z09fvbt/9QpeL1239+PA0eYs8cLQbTbGa U4zOPqFa/IAEQhDEe31c/K7INhFpbYYyd07tnpYzeSlEeCXl4RXfYcin7lIcMa4u CoYUW+Y3J8hCx1uombvD =rt7D -----END PGP SIGNATURE----- --gTtJ75FAzB1T2CN6--