From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
dgibson@redhat.com, qemu-ppc@nongnu.org,
Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured"
Date: Tue, 1 Sep 2015 15:00:25 +1000 [thread overview]
Message-ID: <20150901050025.GA22789@voom.redhat.com> (raw)
In-Reply-To: <1439470382-17540-1-git-send-email-lvivier@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote:
> When a device is hotplugged, attach() sets "configured" to
> false, waiting an action from the OS to configure it and then
> to call ibm,configure-connector. On ibm,configure-connector,
> the hypervisor sets "configured" to true.
>
> In case of coldplugged device, attach() sets "configured" to
> false, but firmware and OS never call the ibm,configure-connector
> in this case, so it remains set to false.
>
> It could be harmless, but when we unplug a device, hypervisor
> waits the device becomes configured because for it, a not configured
> device is a device being configured, so it waits the end of configuration
> to unplug it... and it never happens, so it is never unplugged.
>
> This patch set by default coldplugged device to "configured=true",
> hotplugged device to "configured=false".
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Merged to spapr-next, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-09-01 5:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 12:53 [Qemu-devel] [PATCH RFC] pseries: define coldplugged devices as "configured" Laurent Vivier
2015-08-14 5:20 ` Bharata B Rao
2015-08-14 7:16 ` Laurent Vivier
2015-08-14 7:44 ` Bharata B Rao
2015-08-14 7:46 ` Laurent Vivier
2015-08-23 19:08 ` Michael Roth
2015-08-26 13:04 ` Laurent Vivier
2015-08-14 12:33 ` [Qemu-devel] [Qemu-ppc] " Laurent Vivier
2015-09-01 5:00 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901050025.GA22789@voom.redhat.com \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=dgibson@redhat.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).