From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWdiW-0004Xx-0V for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:02:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWdiR-0005m1-UB for qemu-devel@nongnu.org; Tue, 01 Sep 2015 01:02:43 -0400 Date: Tue, 1 Sep 2015 15:00:25 +1000 From: David Gibson Message-ID: <20150901050025.GA22789@voom.redhat.com> References: <1439470382-17540-1-git-send-email-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <1439470382-17540-1-git-send-email-lvivier@redhat.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH RFC] pseries: define coldplugged devices as "configured" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Michael Roth , dgibson@redhat.com, qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 13, 2015 at 02:53:02PM +0200, Laurent Vivier wrote: > When a device is hotplugged, attach() sets "configured" to > false, waiting an action from the OS to configure it and then > to call ibm,configure-connector. On ibm,configure-connector, > the hypervisor sets "configured" to true. >=20 > In case of coldplugged device, attach() sets "configured" to > false, but firmware and OS never call the ibm,configure-connector > in this case, so it remains set to false. >=20 > It could be harmless, but when we unplug a device, hypervisor > waits the device becomes configured because for it, a not configured > device is a device being configured, so it waits the end of configuration > to unplug it... and it never happens, so it is never unplugged. >=20 > This patch set by default coldplugged device to "configured=3Dtrue", > hotplugged device to "configured=3Dfalse". >=20 > Signed-off-by: Laurent Vivier Merged to spapr-next, thanks. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJV5TDpAAoJEGw4ysog2bOSsMMQAJJvrNsdt78NXMq5eoLOIMap egXU5Rcx9ivklghJOtf8YRD6wZ09KedCwesWASBTBL9+SC1WS8K6bsf79eU8cmZ1 7csonTI6omIJ1Y47pE5xNGSAFoXJI3CS+eP4qR9gUH1LLjWGRgSQ1W32GIFGA7BX usMuMFHxMbPUXk6qWxG7R35fiJuGNYPnX1yR3eAqdxJsz00M91qWEtFebo4+KMuo SKU/lM3yR8wXW832vkK+0uP4TQAtSVIM4N5XgbaEHQTtMq+rcU5rR3GVEAufFKH2 FD07PxfuCly39gCl50puEldNOPf92p8q4QnxwjTnLphRsrIO/imEkyKUQ/Y7dcrR sSd5gsrTloXgtJmjaaT2vkkewOaoJCWEARBiNar16ee9nhzCLr0jyhunXXXpiVSe iTlgCE6xtHCOta2cLSe0qRktE8xqTxI1zI+i4TM0tYxCvowLm4cap47nuO+rq4f/ MdjLEkqXRHct6KFm68dPOlh7wUwdcm9C6HzgprrtZiFLecScdZBpRh+FB7B3ooKv w2VB9MRyMh6Q0eE0mjY9zE8av+iJr9XJJB0ZYUbX7sYgBEOpHN2BzrXFnXJoz71H 8897EwKvOE+OQp90lmCKkbHM4PjhJYpk40IUynz4cn0Aor9QTj5AaPXQFc48tQsZ 0VxVgRps7Oak98zhW511 =ln+3 -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--