From: "Daniel P. Berrange" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Programmingkid <programmingkidx@gmail.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths
Date: Tue, 1 Sep 2015 09:58:14 +0100 [thread overview]
Message-ID: <20150901085814.GB6860@redhat.com> (raw)
In-Reply-To: <55E15616.9030508@redhat.com>
On Sat, Aug 29, 2015 at 08:49:58AM +0200, Paolo Bonzini wrote:
>
>
> On 28/08/2015 14:53, Markus Armbruster wrote:
> > I believe this makes sense no matter what we do about device IDs (see
> > thread "Should we auto-generate IDs?").
>
> I haven't read that huge thread yet, but I think it gives the user too
> much power. There are internal objects that are not supposed to be
> freed, and freeing them would likely result in a SEGV or similar.
I'll double check, but I thought it raised a nice error if the object
did not implement the user-creatable interface.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2015-09-01 8:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 15:37 [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths Daniel P. Berrange
2015-08-27 16:01 ` Eric Blake
2015-08-28 0:29 ` Gonglei
2015-08-28 12:53 ` Markus Armbruster
2015-08-28 12:59 ` Daniel P. Berrange
2015-08-29 6:49 ` Paolo Bonzini
2015-08-29 7:27 ` Gonglei
2015-09-01 8:58 ` Daniel P. Berrange [this message]
2015-09-01 9:12 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150901085814.GB6860@redhat.com \
--to=berrange@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).