From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWhc5-0005is-Hp for qemu-devel@nongnu.org; Tue, 01 Sep 2015 05:12:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWhbz-0003xc-DY for qemu-devel@nongnu.org; Tue, 01 Sep 2015 05:12:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWhbz-0003xY-9C for qemu-devel@nongnu.org; Tue, 01 Sep 2015 05:12:15 -0400 Date: Tue, 1 Sep 2015 10:12:11 +0100 From: "Daniel P. Berrange" Message-ID: <20150901091211.GC6860@redhat.com> References: <1440689864-32127-1-git-send-email-berrange@redhat.com> <87vbbz8tgq.fsf@blackfin.pond.sub.org> <55E15616.9030508@redhat.com> <20150901085814.GB6860@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150901085814.GB6860@redhat.com> Subject: Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Programmingkid , Markus Armbruster , Andreas =?utf-8?Q?F=C3=A4rber?= On Tue, Sep 01, 2015 at 09:58:14AM +0100, Daniel P. Berrange wrote: > On Sat, Aug 29, 2015 at 08:49:58AM +0200, Paolo Bonzini wrote: > > > > > > On 28/08/2015 14:53, Markus Armbruster wrote: > > > I believe this makes sense no matter what we do about device IDs (see > > > thread "Should we auto-generate IDs?"). > > > > I haven't read that huge thread yet, but I think it gives the user too > > much power. There are internal objects that are not supposed to be > > freed, and freeing them would likely result in a SEGV or similar. > > I'll double check, but I thought it raised a nice error if the object > did not implement the user-creatable interface. Ok, I'm wrong - we get an assertion error because it isn't user-creatble and then we abort. I'll send a v3 which returns a pretty error instead of aborting. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|