From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWoaj-0000Pi-AF for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:39:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWoaf-0002rU-P8 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:39:25 -0400 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:39506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWoaf-0002rQ-F7 for qemu-devel@nongnu.org; Tue, 01 Sep 2015 12:39:21 -0400 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Sep 2015 17:39:20 +0100 Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t81GMpTQ40435798 for ; Tue, 1 Sep 2015 16:22:51 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t81GMpXI019029 for ; Tue, 1 Sep 2015 10:22:51 -0600 Date: Tue, 1 Sep 2015 18:22:49 +0200 From: Cornelia Huck Message-ID: <20150901182249.77c46a86.cornelia.huck@de.ibm.com> In-Reply-To: <55E5CCBD.2080102@redhat.com> References: <1441018834-8993-1-git-send-email-cornelia.huck@de.ibm.com> <1441018834-8993-6-git-send-email-cornelia.huck@de.ibm.com> <55E4813C.1050707@redhat.com> <55E4A3AF.500@linux.vnet.ibm.com> <20150901163010.229565fc.cornelia.huck@de.ibm.com> <55E5CCBD.2080102@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 5/8] s390x: Dump-skeys hmp support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, jjherne@linux.vnet.ibm.com, agraf@suse.de On Tue, 1 Sep 2015 10:05:17 -0600 Eric Blake wrote: > On 09/01/2015 08:30 AM, Cornelia Huck wrote: > > >>>> +++ b/hmp-commands.hx > >>>> @@ -1053,6 +1053,22 @@ gdb. Without -z|-l|-s, the dump format is ELF. > >>>> together with begin. > >>>> ETEXI > >>>> > >>>> +#if defined(TARGET_S390X) > >>>> + { > >>>> + .name = "dump-skeys", > >>> > >>> Most HMP commands use '_', not '-', for word separation. > >>> > >> > >> I patterned my new command after dump-guest-memory since the functionality > >> was similar. Though it is easy enough to change if you would like. > > > > Eric, do you have a strong preference? I think either is fine; I can > > either keep it as-is or merge in a change for the pull. > > HMP is not ABI; we can change it at will without worrying about > back-compat issues. Consistency is nice, so I'd lean towards > consistently using _ throughout HMP, but the preference is not strong > enough so I don't object to keeping this commit as-is for the sake of > merging, especially if dump-guest-memory also needs changing (that is, a > followup patch that changes all HMP to be consistent in one go is not > that much harder, even if this patch adds to the workload of that patch). Given that there are even more commands using - and that we can change this later on, I'll just leave it as-is.