From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWqMv-00029u-0q for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZWqMq-0000PV-0w for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:33:16 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:48099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZWqMp-0000O6-TI for qemu-devel@nongnu.org; Tue, 01 Sep 2015 14:33:11 -0400 Received: from /spool/local by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 1 Sep 2015 14:33:10 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 6740438C8039 for ; Tue, 1 Sep 2015 14:33:08 -0400 (EDT) Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t81IX8ol58458132 for ; Tue, 1 Sep 2015 18:33:08 GMT Received: from d01av03.pok.ibm.com (localhost [127.0.0.1]) by d01av03.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t81IX7OB021597 for ; Tue, 1 Sep 2015 14:33:07 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <1441126866-17199-1-git-send-email-mdroth@linux.vnet.ibm.com> Message-ID: <20150901183302.20826.41297@loki> Date: Tue, 01 Sep 2015 13:33:02 -0500 Subject: Re: [Qemu-devel] [PULL 00/26] qemu-ga patch queue for 2015-09-01 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers Quoting Peter Maydell (2015-09-01 12:12:39) > On 1 September 2015 at 18:00, Michael Roth wr= ote: > > The following changes since commit 090d0bfd948343d522cd20bc634105b5cfe2= 483b: > > > > s390: fix softmmu compilation (2015-08-28 16:05:24 +0100) > > > > are available in the git repository at: > > > > git://github.com/mdroth/qemu.git tags/qga-pull-2015-09-01-tag > > > > for you to fetch changes up to 9680171bcd317927c0cbaaa291dd9072e79fb32c: > > > > Makefile: qemu-ga: fix msi target error message (2015-09-01 11:40:35 = -0500) > > > > ---------------------------------------------------------------- > > qemu-ga patch queue > > > > * add config file dump/load support for qemu-ga > > * various w32 build fixes, particularly WRT to msi package creation > > * fixes for msi installer > > * w32 support for guest-set-user-password > = > Hi. I'm afraid this fails to compile with our minimum glib version: > = > /Users/pm215/src/qemu/qga/main.c:1385:5: warning: implicit declaration of > function 'g_list_free_full' is invalid in C99 [-Wimplicit-function-decla= ration] > g_list_free_full(s->blacklist, g_free); > = > That function wasn't added to glib until 2.28, and our minimum is > 2.22. Sorry for missing this, will send a v2 shortly. Do you happen to know a way to check/enforce max version levels for glib functions? Apparently there's a GLIB_VERSION_MAX_ALLOWED that serves this purpose, but it didn't generate any warnings in this particular case: https://developer.gnome.org/glib/stable/glib-Version-Information.html#GLIB-= VERSION-MAX-ALLOWED:CAPS If we could get that working in tree it might help with these glib compat issues (which seem to happen fairly frequently) > = > thanks > -- PMM >=20